Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new KCP CLI in SKR tests #857

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Use new KCP CLI in SKR tests #857

merged 7 commits into from
Jun 17, 2024

Conversation

MarekMichali
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Use new KCP CLI in SKR tests
  • Temporarily Disable tests that use kubeconfig

Related issue(s)

@MarekMichali MarekMichali requested a review from a team as a code owner June 17, 2024 13:40
@MarekMichali
Copy link
Contributor Author

/kind enhancement

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@MarekMichali
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2024
@MarekMichali
Copy link
Contributor Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 17, 2024
@kyma-bot kyma-bot merged commit 48d5f55 into kyma-project:main Jun 17, 2024
24 checks passed
MarekMichali added a commit to MarekMichali/kyma-environment-broker that referenced this pull request Jun 19, 2024
@MarekMichali
Revert "Use new KCP CLI in SKR tests (kyma-project#857)"
8a264a9 
This reverts commit 48d5f55.
kyma-bot pushed a commit that referenced this pull request Jun 20, 2024
@MarekMichali
Re-enable kubeconfig related SKR tests (#870)
1fbdb2c 
* Revert "Use new KCP CLI in SKR tests  (#857)"

This reverts commit 48d5f55.

* Add auth type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarekMichali @jaroslaw-pieszka @kyma-bot