Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Pods and Service CIDRS in provisioning parameters #853

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Provide Pods and Service CIDRS in provisioning parameters #853

merged 2 commits into from
Jun 19, 2024

Conversation

piotrmiskiewicz
Copy link
Member

@piotrmiskiewicz piotrmiskiewicz commented Jun 13, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • allow to provide Pods/Services CIDRs as a provisioning parameter

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@piotrmiskiewicz
Copy link
Member Author

/hold

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 13, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 13, 2024
@piotrmiskiewicz piotrmiskiewicz marked this pull request as ready for review June 13, 2024 13:35
@piotrmiskiewicz piotrmiskiewicz requested a review from a team as a code owner June 13, 2024 13:35
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 13, 2024
@piotrmiskiewicz piotrmiskiewicz added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jun 18, 2024
@piotrmiskiewicz piotrmiskiewicz force-pushed the enable-pods-services-cidr branch from 97d0d44 to 13f9dec Compare June 18, 2024 08:52
@piotrmiskiewicz
Copy link
Member Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2024
@piotrmiskiewicz piotrmiskiewicz added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature labels Jun 18, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2024
@piotrmiskiewicz piotrmiskiewicz force-pushed the enable-pods-services-cidr branch from 8cbea4e to 1bd01ed Compare June 18, 2024 14:33
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 19, 2024
@kyma-bot kyma-bot merged commit 9b27a6c into kyma-project:main Jun 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrmiskiewicz @kyma-bot @jaroslaw-pieszka