Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injecting Region Mapping Config into KEB #820

Merged

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Jun 10, 2024

Description

Passing region mapping to KEB based on mounted config map as it was done in eu whitelist functionality.

Changes proposed in this pull request:

  • default template values in values.yaml,
  • mounting config as container's file through mounted config map volume.
  • config path passed as env variable to KEB envconfig.

Related issue(s)

#793

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 10, 2024
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@ralikio ralikio added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed cla: yes Indicates the PR's author has signed the CLA. labels Jun 10, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jun 10, 2024
Co-authored-by: Jarosław Pieszka <jaroslaw.pieszka@sap.com>
@ralikio ralikio marked this pull request as ready for review June 12, 2024 09:37
@ralikio ralikio requested a review from a team as a code owner June 12, 2024 09:37
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 12, 2024
@kyma-bot kyma-bot merged commit b55b4f1 into kyma-project:main Jun 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants