Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending metrics for subaccount-sync app #721

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Extending metrics for subaccount-sync app #721

merged 2 commits into from
Apr 30, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Apr 29, 2024 •
edited
Loading

Description

To make subaccount-sync observable in a much better way, and to make it possible to setup alerts based on failure ratio.

Changes proposed in this pull request:

  • Counting successes and failures in regard to CIS requests
  • Corrected time_in_queue metric
    Related issue(s)

#691

@jaroslaw-pieszka jaroslaw-pieszka added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature labels Apr 29, 2024
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Apr 29, 2024
@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner April 29, 2024 11:50
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 29, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2024
@jaroslaw-pieszka
counting failures for CIS requests
559a19b 
metrics update back to main loop

extra logging

in-memory stats metrics

metrics for inmemory states corrected

one more call corrected

time conversion done

time conversion corrected with verbose logging

facepalm, we get interval from the queue not point in time

corrected sign
@jaroslaw-pieszka jaroslaw-pieszka force-pushed the metrix-fixes-and-extensions branch from bbb3748 to 559a19b Compare April 30, 2024 10:01
ukff
ukff previously approved these changes Apr 30, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 30, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Apr 30, 2024
@MarekMichali
Copy link
Contributor

/cla

@kyma-bot
Copy link
Contributor

Successfully reached out to cla-assistant.io to initialize recheck of PR #721

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 30, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 30, 2024
@kyma-bot kyma-bot merged commit 045cc86 into kyma-project:main Apr 30, 2024
23 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the metrix-fixes-and-extensions branch August 7, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekMichali MarekMichali MarekMichali approved these changes

@piotrmiskiewicz piotrmiskiewicz piotrmiskiewicz approved these changes

@ukff ukff ukff left review comments

Assignees

@piotrmiskiewicz piotrmiskiewicz

@jaroslaw-pieszka jaroslaw-pieszka

@MarekMichali MarekMichali

@ukff ukff

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaroslaw-pieszka @MarekMichali @kyma-bot @piotrmiskiewicz @ukff