Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max and min expiration time #1255

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Add max and min expiration time #1255

merged 6 commits into from
Oct 4, 2024

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Oct 4, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Set max expiration time to 2 h
  • Set min expiration time to 10 min
  • Make binding config parameters configurable from chart
  • Add unit tests
  • Update docs

Related issue(s)

See #1202

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 4, 2024
@kyma-bot kyma-bot added the area/documentation Issues or PRs related to documentation label Oct 4, 2024
@MarekMichali MarekMichali changed the title Add max expiration time Add max and min expiration time Oct 4, 2024
@MarekMichali
Copy link
Contributor Author

/kind enhancement

@kyma-bot kyma-bot added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 4, 2024
@MarekMichali MarekMichali marked this pull request as ready for review October 4, 2024 09:16
@MarekMichali MarekMichali requested review from a team as code owners October 4, 2024 09:16
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 4, 2024 09:16
ukff
ukff reviewed Oct 4, 2024
View reviewed changes
docs/user/05-60-kyma-bindings.md Outdated
| **expiration_seconds** | `600` | Specifies the duration (in seconds) for which the generated kubeconfig is valid. If not provided, the default value of `600` seconds (10 minutes) is used. The maximum value that can be set is `7200` seconds (2 hours). |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add info that 600 is minmal forced by gardener so like:
If not provided, the default value of 600 seconds (10 minutes) is used, which is minimum value forced by Gardener

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 4, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit d4ddae9 into kyma-project:main Oct 4, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukff ukff ukff approved these changes

@IwonaLanger IwonaLanger IwonaLanger approved these changes

Assignees

@IwonaLanger IwonaLanger

@ukff ukff

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarekMichali @kyma-bot @IwonaLanger @ukff @kyma-gopher-bot