Skip to content

Commit

Permalink
Linter
Browse files Browse the repository at this point in the history
  • Loading branch information
MarekMichali committed Jun 17, 2024
1 parent 7e747ae commit a76d0ad
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
6 changes: 3 additions & 3 deletions testing/e2e/skr/kcp/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class KCPConfig {
return new KCPConfig();
}
constructor() {
this.authType = getEnvOrThrow('KCP_AUTH_TYPE')
this.authType = getEnvOrThrow('KCP_AUTH_TYPE');
this.host = getEnvOrThrow('KCP_KEB_API_URL');
this.kubeConfigApiUrl = getEnvOrThrow('KCP_KUBECONFIG_API_URL');
this.oauthClientID = getEnvOrThrow('KCP_OAUTH2_CLIENT_ID');
Expand All @@ -36,12 +36,12 @@ class KCPWrapper {

const stream = fs.createWriteStream(`${this.kcpConfigPath}`);
stream.once('open', (_) => {
stream.write(`auth-type: "${this.authType}"\n`)
stream.write(`auth-type: "${this.authType}"\n`);
stream.write(`keb-api-url: "${this.host}"\n`);
stream.write(`kubeconfig-api-url: "${this.kubeConfigApiUrl}"\n`);
stream.write(`oauth2-client-id: "${this.oauthClientID}"\n`);
stream.write(`oauth2-client-secret: "${this.oauthSecret}"\n`);
stream.write(`oauth2-issuer-url: "${this.oauthIssuer}"\n`);
stream.write(`oauth2-issuer-url: "${this.oauthIssuer}"\n`);
stream.write(`gardener-namespace: "${this.gardenerNamespace}"\n`);
stream.end();
});
Expand Down
14 changes: 7 additions & 7 deletions testing/e2e/skr/skr-test/oidc/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ function oidcE2ETest(getShootOptionsFunc, getShootInfoFunc) {
await ensureValidOIDCConfigInCustomerFacingKubeconfig(keb, options.instanceID, givenOidcConfig);
});

// it('Assure initial cluster admin', async function() {
// await ensureKymaAdminBindingExistsForUser(options.kebUserId); // default user id
// });
// it('Assure initial cluster admin', async function() {
// await ensureKymaAdminBindingExistsForUser(options.kebUserId); // default user id
// });

it('Update SKR service instance with OIDC config', async function() {
this.timeout(updateTimeout);
Expand Down Expand Up @@ -72,9 +72,9 @@ function oidcE2ETest(getShootOptionsFunc, getShootInfoFunc) {
await ensureValidOIDCConfigInCustomerFacingKubeconfig(keb, options.instanceID, options.oidc1);
});

// it('Assure cluster admin is preserved', async function() {
// await ensureKymaAdminBindingExistsForUser(options.kebUserId);
// });
// it('Assure cluster admin is preserved', async function() {
// await ensureKymaAdminBindingExistsForUser(options.kebUserId);
// });

it('Update SKR service instance with new admins', async function() {
this.timeout(updateTimeout);
Expand All @@ -99,7 +99,7 @@ function oidcE2ETest(getShootOptionsFunc, getShootInfoFunc) {
console.log(`\nRuntime status: ${runtimeStatus}`);
});

/* it('Assure only new cluster admins are configured', async function() {
/* it('Assure only new cluster admins are configured', async function() {
await ensureKymaAdminBindingExistsForUser(options.administrators1[0]);
await ensureKymaAdminBindingExistsForUser(options.administrators1[1]);
await ensureKymaAdminBindingDoesNotExistsForUser(options.kebUserId);
Expand Down
2 changes: 1 addition & 1 deletion testing/e2e/skr/skr-test/provision/provision-skr.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ async function provisionSKRAndInitK8sConfig(options, provisioningTimeout) {
await initK8sConfig(shoot);
} else {
console.log('Initiating K8s client... skipped');
//await initializeK8sClient({kubeconfigPath: shoot.kubeconfig});
// await initializeK8sClient({kubeconfigPath: shoot.kubeconfig});
}

console.log('Initialization of K8s finished...');
Expand Down
2 changes: 1 addition & 1 deletion testing/e2e/skr/skr-test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ describe('SKR test', function() {
});

// Run BTP Manager Secret tests
//btpManagerSecretTest();
// btpManagerSecretTest();

// Run OIDC tests
oidcE2ETest(getShootOptionsFunc, getShootInfoFunc);
Expand Down

0 comments on commit a76d0ad

Please sign in to comment.