[QG][KIM] Application that generates loads by creating or deleting Runtime CR #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
kyma-bot
added
size/XL
koala7659
reviewed
Oct 18, 2024
hack/performance/cmd/cmd.go
Outdated
| switch os.Args[1] { | ||
| case "create": | ||
| createCmd.Parse(os.Args[2:]) | ||
| if *loadID == "" || *namePrefix == "" || *kubeconfig == "" || *rtNumber == 0 { |
There was a problem hiding this comment.
The flag templatePath is also required and should be also checked here
hack/performance/cmd/cmd.go
Outdated
| kubeconfig := createCmd.String("kubeconfig", "", "the path to the kubeconfig file (required)") | ||
| rtNumber := createCmd.Int("rt-number", 0, "the number of the runtimes to be created (required)") | ||
| templatePath := createCmd.String("rt-template", "", "the path to the yaml file with the runtime template (required)") | ||
| runOnCi := createCmd.String("run-on-ci", "false", "identifies if the load is running on CI") |
There was a problem hiding this comment.
I suggest to change type of this flag to Bool if possible - this will avoid problem in line 70 if a user provides anything different than "false"
| return Unknown, nil, err | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
if a user provides anything different than "false" ex "FALSE" or "aaaaa" the code under if statement will not be executed.
I suggest:
- use flag.Bool type for this parameter runOnCi
- Change this code into:
if *runOnCi == false {
}
| } | ||
|
|
||
| func readFromSource(reader io.Reader) (imv1.Runtime, error) { | ||
| data, err := io.ReadAll(reader) |
There was a problem hiding this comment.
The error value is not handled
mvshao
added
the
do-not-merge/hold
grego952
reviewed
Oct 21, 2024
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
grego952
previously approved these changes
Oct 21, 2024
koala7659
reviewed
Oct 21, 2024
Co-authored-by: Przemyslaw Golicz <przemyslaw.golicz@sap.com>
grego952
approved these changes
Oct 21, 2024
mvshao
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The program is used to generate performance test loads by creating or deleting Runtime CR in a given Kubernetes cluster.
Changes proposed in this pull request:
Related issue(s)
#14