Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare job #394

Merged
merged 11 commits into from
Sep 24, 2024
Merged

Fix compare job #394

merged 11 commits into from
Sep 24, 2024

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Sep 20, 2024

Description

Changes proposed in this pull request:

  • Fixed the way comparator filters shoot files
  • KIM adds creationTimestamp to allow comparator to filter out files older than specific date

Related issue(s)
kyma-project/control-plane#3478

@akgalwas akgalwas requested review from a team as code owners September 20, 2024 13:01
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2024
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 24, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 24, 2024
@kyma-bot kyma-bot merged commit aeb9d12 into kyma-project:main Sep 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants