-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubeconfig access handling #323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add code to update status when the function is successful
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Outdated
Show resolved
Hide resolved
5def1a1
to
3f1bae4
Compare
e9d6b69
to
f0ce08a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Outdated
Show resolved
Hide resolved
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Show resolved
Hide resolved
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Outdated
Show resolved
Hide resolved
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Show resolved
Hide resolved
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Outdated
Show resolved
Hide resolved
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Outdated
Show resolved
Hide resolved
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Outdated
Show resolved
Hide resolved
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Show resolved
Hide resolved
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Show resolved
Hide resolved
…indings.go Co-authored-by: Przemyslaw Golicz <przemyslaw.golicz@sap.com>
09f3bac
to
0ef59b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Changes proposed in this pull request:
Related issue(s)
See also:
ClusterRoleBindings
if theadminstrators
change when clusters are created or updated #198