Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubeconfig access handling #323

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Aug 2, 2024

Description

Changes proposed in this pull request:

  • Add kubeconfig access handling

Related issue(s)

See also:

@m00g3n m00g3n requested a review from a team as a code owner August 2, 2024 07:15
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2024
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add code to update status when the function is successful

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 12, 2024
@m00g3n m00g3n force-pushed the handle-kubeconfig-access branch from 5def1a1 to 3f1bae4 Compare August 12, 2024 09:35
@m00g3n m00g3n force-pushed the handle-kubeconfig-access branch from e9d6b69 to f0ce08a Compare August 12, 2024 10:45
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

@m00g3n m00g3n force-pushed the handle-kubeconfig-access branch from 09f3bac to 0ef59b3 Compare August 14, 2024 07:51
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 14, 2024
@kyma-bot kyma-bot merged commit 74f7687 into kyma-project:main Aug 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants