Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for making shoot comparison easier #322

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Fixes for making shoot comparison easier #322

merged 5 commits into from
Aug 6, 2024

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Aug 2, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Matchers perform more granular comparison to make results easier to read
  • Annotations are not compared as both KIM and Provisioner create different annotations set
  • Shoot spec stored on the persistent volume does not contain fields that are not relevant for comparison
  • Shoot spec not stored on upgrade to align with the Provisioner

Related issue(s)
#185

@akgalwas akgalwas requested a review from a team as a code owner August 2, 2024 05:19
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2024
@akgalwas akgalwas mentioned this pull request Aug 2, 2024
Closed
4 tasks
@akgalwas akgalwas changed the title [WiP] Fixes for making shoot comparison easier Fixes for making shoot comparison easier Aug 2, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2024
m00g3n
m00g3n approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 6, 2024
@kyma-bot kyma-bot merged commit cb62cc3 into kyma-project:main Aug 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

Assignees

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akgalwas @m00g3n @kyma-bot