-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ADR for the provisioning functionality in KIM #202
Conversation
Skipping CI for Draft Pull Request. |
This reverts commit adf0029.
Do you happen to have a structure for the RuntimeKubeconfig CR? I believe this is something that the Lifecycle Manager would need to consume. It would be great to set up a contract upfront. |
when configuring an additional workflow OIDC it will be common that
I checked that it is possible to pass such strings among administrators via KEB, for example
.. so it should work.. but my gut feeling tells me it could be a bit confusing @pbochynski @PK85 |
@janmedrek You can find the structure here: https://github.com/kyma-project/infrastructure-manager/blob/main/api/v1/gardenercluster_types.go . At some point we will rename |
I think it is ok, but maybe we can have administrators in the additional OIDC config section. Then we do not need to add prefix in the list. |
@pbochynski @kwiatekus I would go with the current proposal. I don't see a huge gain from adding administrators list under additional OIDC config (it also adds some confusion, as fields under spec.shoot are designed to be used solely for shoot generation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Changes proposed in this pull request:
Related issue(s)
#125