Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ADR for the provisioning functionality in KIM #202

Merged
merged 50 commits into from
May 21, 2024

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented May 8, 2024

Description

Changes proposed in this pull request:

  • ADR describing provisioning functionality in the Kyma Infrastructure Manager

Related issue(s)
#125

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented May 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 8, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 8, 2024
@janmedrek
Copy link

janmedrek commented May 14, 2024

Do you happen to have a structure for the RuntimeKubeconfig CR? I believe this is something that the Lifecycle Manager would need to consume. It would be great to set up a contract upfront.

@kyma-bot kyma-bot added the lgtm Looks good to me! label May 14, 2024
@kwiatekus
Copy link

kwiatekus commented May 14, 2024

when configuring an additional workflow OIDC it will be common that cluster-admin role would need to be assigned to a "github identity" where the "user" field is configured to identify a certain github ref from a github repo, i.e :

kind: ClusterRoleBinding
...
subjects:
  - apiGroup: rbac.authorization.k8s.io
    kind: User
    name: actions-oidc:repo:myOrg/myRepo:ref:refs/heads/main

I checked that it is possible to pass such strings among administrators via KEB, for example

  "administrators": [
    "admin@mail.com",
    "actions-oidc:repo:myOrg/myRepo:ref:refs/heads/main"
  ]

.. so it should work.. but my gut feeling tells me it could be a bit confusing

@pbochynski @PK85
Is it ok from your point of view to mix users (identified by email) with workflow identities under one field "administrators" ?

@kwiatekus kwiatekus removed their assignment May 14, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 14, 2024
@akgalwas
Copy link
Contributor Author

Do you happen to have a structure for the RuntimeKubeconfig CR? I believe this is something that the Lifecycle Manager would need to consume. It would be great to set up a contract upfront.

@janmedrek You can find the structure here: https://github.com/kyma-project/infrastructure-manager/blob/main/api/v1/gardenercluster_types.go . At some point we will rename GardenerCluster CR to RuntimeKubeconfig

@pbochynski
Copy link
Contributor

@pbochynski @PK85 Is it ok from your point of view to mix users (identified by email) with workflow identities under one field "administrators" ?

I think it is ok, but maybe we can have administrators in the additional OIDC config section. Then we do not need to add prefix in the list.

@akgalwas
Copy link
Contributor Author

@pbochynski @PK85 Is it ok from your point of view to mix users (identified by email) with workflow identities under one field "administrators" ?

I think it is ok, but maybe we can have administrators in the additional OIDC config section. Then we do not need to add prefix in the list.

@pbochynski @kwiatekus I would go with the current proposal. I don't see a huge gain from adding administrators list under additional OIDC config (it also adds some confusion, as fields under spec.shoot are designed to be used solely for shoot generation)

Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.