Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing strategy for Infrastructure Manager #133

Merged
merged 23 commits into from
Feb 22, 2024

Conversation

grego952
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add testing strategy for Infrastructure Manager

Related issue(s)
Fixes #120

@grego952 grego952 added area/documentation Issues or PRs related to documentation do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 25, 2024
@grego952 grego952 requested a review from a team as a code owner January 25, 2024 07:27
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2024
@Disper Disper assigned Cortey and Disper and unassigned Cortey Jan 25, 2024
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
@Disper
Copy link
Member

Disper commented Jan 25, 2024

I'm not an expert in writing testing strategies but I see value in the CI inventory introduced in this PR.

Co-authored-by: Michał 'Disper' Drzewiecki <michal.drzewiecki@sap.com>
@grego952 grego952 requested a review from Disper January 25, 2024 12:05
Disper
Disper previously approved these changes Jan 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 25, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 26, 2024
@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ grego952
❌ tobiscr
You have signed the CLA already but the status is still pending? Let us recheck it.

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 26, 2024
tobiscr
tobiscr previously approved these changes Feb 20, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 20, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 20, 2024
tobiscr
tobiscr previously approved these changes Feb 20, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 20, 2024
@grego952 grego952 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved
Co-authored-by: Iwona Langer <iwona.langer@sap.com>
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2024
tobiscr
tobiscr previously approved these changes Feb 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 22, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 22, 2024
@kyma-bot kyma-bot merged commit 42c6730 into kyma-project:main Feb 22, 2024
7 checks passed
@grego952 grego952 deleted the testing-strategy branch February 22, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define testing concept for Kyma Infrastructure Manager
8 participants