Merge pull request #437 from akgalwas/fix-comparator-unit-tests

Fixed regression in Comparator tests
kyma-project · Oct 23, 2024 · 52d06e2 · 52d06e2
2 parents a98775a + bc29069
commit 52d06e2
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/hack/shoot-comparator/pkg/shoot/matcher.go b/hack/shoot-comparator/pkg/shoot/matcher.go
@@ -72,6 +72,11 @@ func (m *Matcher) Match(actual interface{}) (success bool, err error) {
 			actual:        shootActual.Spec.Extensions,
 			path:          "spec/extensions",
 		},
+		{
+			GomegaMatcher: gomega.BeComparableTo(shootToMatch.Spec.CloudProfileName),
+			actual:        shootActual.Spec.CloudProfileName,
+			path:          "spec/cloudProfileName",
+		},
 		{
 			GomegaMatcher: gstruct.MatchFields(gstruct.IgnoreMissing, gstruct.Fields{
 				"ClusterAutoscaler":           gstruct.Ignore(),

diff --git a/hack/shoot-comparator/pkg/shoot/matcher_test.go b/hack/shoot-comparator/pkg/shoot/matcher_test.go
@@ -124,6 +124,26 @@ var _ = Describe(":: shoot matcher :: ", func() {
 			deepCp(empty, withLabels(map[string]string{})),
 			false,
 		),
+		Entry(
+			"should detect differences in spec/exposureClassName #1",
+			deepCp(empty, withShootSpec(v1beta1.ShootSpec{
+				ExposureClassName: ptr.To[string]("mage"),
+			})),
+			deepCp(empty, withShootSpec(v1beta1.ShootSpec{
+				ExposureClassName: ptr.To[string]("bard"),
+			})),
+			false,
+		),
+		Entry(
+			"should detect no differences in spec/exposureClassName #1",
+			deepCp(empty, withShootSpec(v1beta1.ShootSpec{
+				ExposureClassName: ptr.To[string]("mage"),
+			})),
+			deepCp(empty, withShootSpec(v1beta1.ShootSpec{
+				ExposureClassName: ptr.To[string]("mage"),
+			})),
+			true,
+		),
 		Entry(
 			"should detect differences in spec/secretBindingName #1",
 			deepCp(empty, withShootSpec(v1beta1.ShootSpec{