This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polskikiel
requested review from
adamwalach,
jasiu001,
ksputo,
mszostok,
piotrmiskiewicz and
PK85
as code owners
June 8, 2020 07:34
polskikiel
force-pushed
the
sc-k8s
branch
4 times, most recently
from
June 9, 2020 08:52
21700b9
to
818dcd2
Compare
polskikiel
force-pushed
the
sc-k8s
branch
2 times, most recently
from
June 9, 2020 09:15
e3ac474
to
3c65bbd
Compare
polskikiel
force-pushed
the
sc-k8s
branch
16 times, most recently
from
June 9, 2020 16:37
dd7c8ba
to
a9afd83
Compare
) | ||
|
||
type contextKey int | ||
|
||
const ( | ||
osbAPIVersion = "2.13" | ||
osbAPIVersion = "2.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find all occurrences of 2.13 and replace it by 2.14 (for example in installation.md)
polskikiel
requested review from
alexandra-simeonova,
bszwarc,
kazydek,
klaudiagrz,
majakurcius,
mmitoraj and
tomekpapiernik
as code owners
June 10, 2020 08:40
piotrmiskiewicz
previously approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/retest |
klaudiagrz
previously approved these changes
Jun 10, 2020
polskikiel
dismissed stale reviews from klaudiagrz and piotrmiskiewicz
via
June 10, 2020 09:29
47a74bc
polskikiel
force-pushed
the
sc-k8s
branch
7 times, most recently
from
June 10, 2020 12:07
2b8c949
to
079dbab
Compare
piotrmiskiewicz
approved these changes
Jun 10, 2020
piotrmiskiewicz
approved these changes
Jun 10, 2020
klaudiagrz
approved these changes
Jun 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)