Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

Implement go modules and k8s 1.18 #100

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Conversation

polskikiel
Copy link
Contributor

@polskikiel polskikiel commented Jun 8, 2020

Description

Changes proposed in this pull request:

  • Implemented go modules and k8s 1.18

Related issue(s)

@polskikiel polskikiel force-pushed the sc-k8s branch 2 times, most recently from e3ac474 to 3c65bbd Compare June 9, 2020 09:15
@polskikiel polskikiel force-pushed the sc-k8s branch 16 times, most recently from dd7c8ba to a9afd83 Compare June 9, 2020 16:37
)

type contextKey int

const (
osbAPIVersion = "2.13"
osbAPIVersion = "2.14"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find all occurrences of 2.13 and replace it by 2.14 (for example in installation.md)

Copy link
Collaborator

@piotrmiskiewicz piotrmiskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polskikiel
Copy link
Contributor Author

/retest

klaudiagrz
klaudiagrz previously approved these changes Jun 10, 2020
@polskikiel polskikiel dismissed stale reviews from klaudiagrz and piotrmiskiewicz via 47a74bc June 10, 2020 09:29
@polskikiel polskikiel force-pushed the sc-k8s branch 7 times, most recently from 2b8c949 to 079dbab Compare June 10, 2020 12:07
@polskikiel polskikiel merged commit ac5be40 into SAP-archive:master Jun 10, 2020
@polskikiel polskikiel deleted the sc-k8s branch June 10, 2020 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants