Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

Commit

Permalink
fix osb version in comments and docs
Browse files Browse the repository at this point in the history
  • Loading branch information
polskikiel committed Jun 10, 2020
1 parent 803c47a commit 47a74bc
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ test:: unit-test integration-test

.PHONY: build-binaries
build-binaries:
go version
./hack/build-binaries.sh

.PHONY: integration-test
Expand Down
2 changes: 1 addition & 1 deletion docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ go run cmd/broker/main.go
Now you can test the Broker using the **/v2/catalog** endpoint.

```bash
curl -H "X-Broker-API-Version: 2.13" localhost:8080/cluster/v2/catalog
curl -H "X-Broker-API-Version: 2.14" localhost:8080/cluster/v2/catalog
```

5. Start the Controller:
Expand Down
2 changes: 1 addition & 1 deletion internal/addon/loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ func loadPlanSchema(basePath, fileName string, required bool) (*internal.PlanSch
}

// OSB API defines: Schemas MUST NOT be larger than 64kB.
// See: https://github.com/openservicebrokerapi/servicebroker/blob/v2.13/spec.md#schema-object
// See: https://github.com/openservicebrokerapi/servicebroker/blob/v2.14/spec.md#schema-object
if len(b) >= maxSchemaLength {
return nil, fmt.Errorf("schema %s is larger than 64 kB", fileName)
}
Expand Down
2 changes: 1 addition & 1 deletion internal/broker/dto.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"github.com/pkg/errors"
)

// DTOs for Open Service Broker v2.13 API
// DTOs for Open Service Broker v2.14 API

type contextDTO struct {
Platform string `json:"platform"`
Expand Down
4 changes: 2 additions & 2 deletions internal/broker/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -575,11 +575,11 @@ func (srv *Server) writeErrorResponse(w http.ResponseWriter, code int, errorMsg,
func writeErrorResponse(w http.ResponseWriter, code int, errorMsg, desc string) {
dto := struct {
// Error is a machine readable info on an error.
// As of 2.13 Open Broker API spec it's NOT passed to entity querying the catalog.
// As of 2.14 Open Broker API spec it's NOT passed to entity querying the catalog.
Error string `json:"error,optional"`

// Desc is a meaningful error message explaining why the request failed.
// see: https://github.com/openservicebrokerapi/servicebroker/blob/v2.13/spec.md#broker-errors
// see: https://github.com/openservicebrokerapi/servicebroker/blob/v2.14/spec.md#broker-errors
Desc string `json:"description,optional"`
}{}

Expand Down
2 changes: 1 addition & 1 deletion internal/storage/driver/etcd/entity_addon.go
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ func newAddonDSO(in *internal.Addon) (*addonDSO, error) {
type addonDSO struct {
ID internal.AddonID
Name internal.AddonName
Version string
Version semver.Version
Description string
Plans map[internal.AddonPlanID]addonPlanDSO
Metadata internal.AddonMetadata
Expand Down

0 comments on commit 47a74bc

Please sign in to comment.