Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor provisioner tests env #3424

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Apr 18, 2024

Description

Changes proposed in this pull request:

  • Remove multiple layers of docker from tests
  • Modify workflow to use actions/setup-go@v5
  • Bump buildpack
  • Remove special test-env handling from database code

Related issue(s)

#3287

@VOID404 VOID404 requested review from a team and ebensom as code owners April 18, 2024 08:01
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2024
@VOID404 VOID404 changed the title Refactor provisioner tests env [WIP] Refactor provisioner tests env Apr 18, 2024
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2024
@VOID404
Copy link
Contributor Author

VOID404 commented Apr 18, 2024

E2e tests pass, with fixed CIDRs
image

@VOID404
Copy link
Contributor Author

VOID404 commented Apr 18, 2024

/retest

1 similar comment
@VOID404
Copy link
Contributor Author

VOID404 commented Apr 18, 2024

/retest

@VOID404 VOID404 force-pushed the refactor-unit-test branch from 426344b to 9226722 Compare April 18, 2024 13:03
@VOID404
Copy link
Contributor Author

VOID404 commented Apr 18, 2024

/retest

@VOID404 VOID404 changed the title [WIP] Refactor provisioner tests env Refactor provisioner tests env Apr 18, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2024
@VOID404 VOID404 removed the request for review from ebensom April 18, 2024 13:35
VOID404 added 4 commits April 18, 2024 15:59
Now tests are run without buildpack by default.
This changes DB code to remove special handling of test environment.
@VOID404 VOID404 requested a review from a team as a code owner April 19, 2024 12:28
@kyma-bot kyma-bot added the area/documentation Issues or PRs related to documentation label Apr 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 19, 2024
@kyma-bot kyma-bot merged commit a798597 into kyma-project:main Apr 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants