-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provisioner creates "istio-system" namespace as part of "create operator bindings" step #3415
Provisioner creates "istio-system" namespace as part of "create operator bindings" step #3415
Conversation
/test tide |
@koala7659: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
@koala7659: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One of installed Kyma componenets "compass-runtime-agent" requires
istio-system
namespace to be correctly initialised. This namespace was created by the Provisioner as part of Runtime configuration step where Provisioner created secrets on the cluster that allowed to establish connection between compass-runtime-agent and Compass.New version of the provisioner delivered by this PR makes Compass Registration process optional, controlled by env variables.
There was a bug in the code where after disabling Compass Registration - The Provisioner has stopped creating
istio-system
namespace as well.This PR is suppose to mitigate this problem by moving namespace creation code into "create operator bindings" step