Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioner creates "istio-system" namespace as part of "create operator bindings" step #3415

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented Mar 20, 2024

One of installed Kyma componenets "compass-runtime-agent" requires istio-system namespace to be correctly initialised. This namespace was created by the Provisioner as part of Runtime configuration step where Provisioner created secrets on the cluster that allowed to establish connection between compass-runtime-agent and Compass.

New version of the provisioner delivered by this PR makes Compass Registration process optional, controlled by env variables.

There was a bug in the code where after disabling Compass Registration - The Provisioner has stopped creating istio-system namespace as well.

This PR is suppose to mitigate this problem by moving namespace creation code into "create operator bindings" step

@koala7659 koala7659 requested a review from a team as a code owner March 20, 2024 11:34
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 20, 2024
@koala7659 koala7659 changed the title Create istio-system namespace as part of create operator bindings step Provisioner creates istio-system namespace as part of create operator bindings step Mar 20, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 20, 2024
@koala7659 koala7659 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@koala7659 koala7659 changed the title Provisioner creates istio-system namespace as part of create operator bindings step Provisioner creates "istio-system" namespace as part of create operator bindings step Mar 20, 2024
@koala7659 koala7659 changed the title Provisioner creates "istio-system" namespace as part of create operator bindings step Provisioner creates "istio-system" namespace as part of "create operator bindings" step Mar 20, 2024
@koala7659 koala7659 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@koala7659
Copy link
Contributor Author

/test tide

@kyma-bot
Copy link
Contributor

@koala7659: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pre-control-plane-components-provisioner
  • /test pre-control-plane-components-schema-migrator
  • /test pre-control-plane-tests-e2e-provisioning
  • /test pre-control-plane-tests-provisioner-tests
  • /test pre-control-plane-validate-dockerfiles
  • /test pull-control-plane-checkconfig
  • /test pull-control-plane-pjconfigtest
  • /test pull-control-plane-pjtester
  • /test pull-control-plane-vpathguard
  • /test pull-e2e-provisioning-test-build
  • /test pull-provisioner-build
  • /test pull-provisioner-tests-build
  • /test pull-schema-migrator-build

The following commands are available to trigger optional jobs:

  • /test pre-control-plane-presubmit-scanner
  • /test pre-main-control-plane-reconciler-e2e
  • /test pre-main-control-plane-reconciler-e2e-latest-release
  • /test pre-main-provisioner-e2e-tests
  • /test pull-control-plane-rec-upgrade-kyma2-stable-to-main-grdnr

Use /test all to run the following jobs that were automatically triggered:

  • pre-control-plane-components-provisioner
  • pre-control-plane-presubmit-scanner
  • pre-main-provisioner-e2e-tests
  • pull-provisioner-build

In response to this:

/test tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@koala7659
Copy link
Contributor Author

/test all

@kyma-bot
Copy link
Contributor

@koala7659: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-provisioner-e2e-tests 9d04432 link false /test pre-main-provisioner-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 20, 2024
@kyma-bot kyma-bot merged commit dd88e90 into kyma-project:main Mar 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants