Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace managed with channel #2186

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Replace managed with channel #2186

merged 4 commits into from
Jul 10, 2024

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Jul 10, 2024

Description

Changes proposed in this pull request:

  • use fields from the Kyma CR status (not spec)
  • print from which channel module is
  • remove the Managed field

Related issue(s)

@pPrecel pPrecel added kind/feature Categorizes issue or PR as related to a new feature. area/cli Related to all activities around CLI labels Jul 10, 2024
@pPrecel pPrecel requested a review from a team as a code owner July 10, 2024 15:05
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 10, 2024
@kyma-bot kyma-bot merged commit 6b69462 into kyma-project:main Jul 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoipm anoipm anoipm approved these changes

Assignees

@anoipm anoipm

Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pPrecel @anoipm @kyma-bot