Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DNS entries creation #95

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix DNS entries creation #95

merged 1 commit into from
Jan 29, 2025

Conversation

rrashidov
Copy link
Contributor

  • hostname retrieved from ingress LoadBalancer service is used to create DNS entries; this works on AWS; however, on other IaaS providers (GCP, Azure, CCEE) the LoadBalancer services does not have hostname assigned; it has IP address assigned; the reconciler is fixed to handle this situation and work with whatever is assigned on the LoadBalancer service

@rrashidov
Fix DNS entries creation
1641f16 
- hostname retrieved from ingress LoadBalancer service is used
  to create DNS entries; this works on AWS; however, on other
  IaaS providers (GCP, Azure, CCEE) the LoadBalancer services
  does not have hostname assigned; it has IP address assigned;
  the reconciler is fixed to handle this situation and work
  with whatever is assigned on the LoadBalancer service
@rrashidov rrashidov requested a review from szeort January 29, 2025 08:14
@kyma-bot kyma-bot added the lgtm label Jan 29, 2025
@kyma-bot kyma-bot merged commit 41caceb into rel-0.2.0 Jan 29, 2025
3 checks passed
@rrashidov rrashidov deleted the fix-dns-entries-creation branch January 29, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szeort szeort szeort approved these changes

Assignees

@szeort szeort

Labels
cla: yes lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rrashidov @szeort @kyma-bot