Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use correct paths for cluster urls #3652

Merged
merged 11 commits into from
Feb 4, 2025
Merged

fix: Use correct paths for cluster urls #3652

merged 11 commits into from
Feb 4, 2025

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Jan 31, 2025 •
edited by KonradPietocha
Loading

Description

Changes proposed in this pull request:

  • fix cluster paths

Related issue(s)
Fixes #3534

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 31, 2025
@dbadura dbadura changed the title fix: Use correct paths fix: Use correct paths for cluster urls Jan 31, 2025
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2025
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2025
@dbadura dbadura linked an issue Jan 31, 2025 that may be closed by this pull request
Custom Resources with open details redirect incorrectly after refresh #3534
Open
akucharska
akucharska previously approved these changes Feb 3, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 3, 2025
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 3, 2025
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 4, 2025
@mrCherry97 mrCherry97 merged commit 51f2213 into kyma-project:main Feb 4, 2025
19 checks passed
@dbadura dbadura deleted the fix-cluster-paths branch February 4, 2025 15:26
OliwiaGowor added a commit that referenced this pull request Feb 5, 2025
@OliwiaGowor
Revert "fix: Use correct paths for cluster urls (#3652)"
0748b3f 
This reverts commit 51f2213.
@OliwiaGowor OliwiaGowor mentioned this pull request Feb 5, 2025
Merged
akucharska pushed a commit that referenced this pull request Feb 5, 2025
@OliwiaGowor
Revert "fix: Use correct paths for cluster urls (#3652)" (#3660)
e2d9f8a 
This reverts commit 51f2213.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska akucharska approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Resources with open details redirect incorrectly after refresh
5 participants
@dbadura @akucharska @kyma-bot @mrCherry97 @KonradPietocha