Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Condition list highlights #3608

Merged
merged 9 commits into from
Jan 23, 2025
Merged

feat: Condition list highlights #3608

merged 9 commits into from
Jan 23, 2025

Conversation

akucharska
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add possibility to override status badges types in Condition List
  • Mark 'Unknown' badges as information.

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2025
@akucharska akucharska linked an issue Jan 20, 2025 that may be closed by this pull request
Allow overriding colors for specific conditions #3575
Closed
OliwiaGowor
OliwiaGowor previously approved these changes Jan 21, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 21, 2025
@akucharska @grego952
Apply suggestions from code review
dd6c7a3 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 22, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2025
@mrCherry97 mrCherry97 merged commit c947a6d into kyma-project:main Jan 23, 2025
15 checks passed
@mrCherry97 mrCherry97 deleted the condition-list-highlights branch January 23, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@grego952 grego952 grego952 approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@grego952 grego952

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow overriding colors for specific conditions
5 participants
@akucharska @grego952 @OliwiaGowor @kyma-bot @mrCherry97