Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open dropdown popover correctly #3594

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Jan 15, 2025

Description

Changes proposed in this pull request:

  • directly pass props to related components (instead of ...props syntax) for better clarity
  • removed unused properties inlineHelp, enableResource
  • use ref instead of id to open popover
  • change popover opening logic to correctly open for both clicking inside the input or on the icon

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2025
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2025
@mrCherry97 mrCherry97 self-assigned this Jan 16, 2025
selectedKey={''}
fullWidth={false}
disabled={disabled}
selectedKey=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary?

Suggested change
selectedKey=""

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 16, 2025
@chriskari chriskari merged commit 62e7294 into kyma-project:ui5-migrate-v2 Jan 16, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants