feat: enhance Ingress details view #3205
Conversation
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
cla: yes
OliwiaGowor
requested review from
a team,
akucharska,
mrCherry97 and
chriskari
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
| t('ingresses.labels.secret-name'), | ||
| ]} | ||
| rowRenderer={tls => [ | ||
| tls?.hosts?.join(', ') ?? EMPTY_TEXT_PLACEHOLDER, |
There was a problem hiding this comment.
I think it would make sense to use the <Tokens> component here instead of joining strings
| }); | ||
|
|
||
| setHealthyPods(healthyPods); | ||
| }; |
There was a problem hiding this comment.
we can merge these two methods, using a single loop for both
also, is the naming pods vs. ports intended?
There was a problem hiding this comment.
No, it was a typo :)
| cy.getMidColumn() | ||
| .contains(/tls/i) | ||
| .should('be.visible'); | ||
|
|
There was a problem hiding this comment.
you could add a check if the given hosts and secretName are displayed correctly :)
| ), | ||
| }, | ||
| customContent: [ | ||
| ...(ingress.hostname |
There was a problem hiding this comment.
as far as I see we can remove those spread operators here and below and simply not place the resulting object inside of an array
| {`${t('ingresses.labels.host-name')}:`} | ||
| </span> | ||
| {`${ingress.hostname}`} | ||
| </div> |
There was a problem hiding this comment.
can we replace this somehow with a UI5 component?
There was a problem hiding this comment.
I don't think so, that's how we are doing it in metadata and status - Labels have slightly different color
Description
Changes proposed in this pull request:
Related issue(s)
Closes #3067
Definition of done
backlog#4567