Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pass fallback namespace to datasources #3202

Merged
merged 1 commit into from
Aug 21, 2024
Merged

feat: Pass fallback namespace to datasources #3202

merged 1 commit into from
Aug 21, 2024

Conversation

akucharska
Copy link
Contributor

@akucharska akucharska commented Aug 20, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Pass fallback namespace to datasources so on extensibility lists datasources can be filtered by current namespace

Related issue(s)
#2574

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2024
@akucharska akucharska linked an issue Aug 20, 2024 that may be closed by this pull request
Dropdown for target input DNSEntries #2574
Closed
@mrCherry97 mrCherry97 self-assigned this Aug 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 21, 2024
@kyma-bot kyma-bot merged commit 584d912 into kyma-project:main Aug 21, 2024
20 checks passed
@mrCherry97 mrCherry97 deleted the data-sources-fallback-namespace branch August 21, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdown for target input DNSEntries
3 participants
@akucharska @mrCherry97 @kyma-bot