Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move Busola web and backend build to github actions #3124

Merged
merged 10 commits into from
Aug 16, 2024

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Aug 14, 2024

Description

Changes proposed in this pull request:

  • added Busola web build to Github actions
  • added Busola backend build to Github actions
  • removed test job from Busola local

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2024
@OliwiaGowor OliwiaGowor marked this pull request as ready for review August 14, 2024 08:42
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2024
@OliwiaGowor OliwiaGowor marked this pull request as draft August 14, 2024 08:44
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2024
@OliwiaGowor
Copy link
Contributor Author

/test all

@OliwiaGowor OliwiaGowor changed the title move busola web build to github actions feat: move busola web build to github actions Aug 14, 2024
@OliwiaGowor OliwiaGowor changed the title feat: move busola web build to github actions chore: move busola web build to github actions Aug 14, 2024
@OliwiaGowor OliwiaGowor changed the title chore: move busola web build to github actions feat: move busola web build to github actions Aug 16, 2024
@OliwiaGowor OliwiaGowor changed the title feat: move busola web build to github actions feat: move Busola web and backend build to github actions Aug 16, 2024
@OliwiaGowor OliwiaGowor marked this pull request as ready for review August 16, 2024 07:32
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2024
Comment on lines 7 to 26
paths:
- ".github/workflows/busola-backend-build.yml"
- "backend/**"
- "public/**"
- "src/**"
- "tests/**"
- "package.json"
- "Makefile"
- "Dockerfile"
pull_request_target:
types: [opened, edited, synchronize, reopened, ready_for_review]
paths:
- ".github/workflows/busola-backend-build.yml"
- "backend/**"
- "public/**"
- "src/**"
- "tests/**"
- "package.json"
- "Makefile"
- "Dockerfile"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 7 to 26
paths:
- ".github/workflows/busola-web-build.yml"
- "backend/**"
- "public/**"
- "src/**"
- "tests/**"
- "package.json"
- "Makefile"
- "Dockerfile"
pull_request_target:
types: [opened, edited, synchronize, reopened, ready_for_review]
paths:
- ".github/workflows/busola-web-build.yml"
- "backend/**"
- "public/**"
- "src/**"
- "tests/**"
- "package.json"
- "Makefile"
- "Dockerfile"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paths should be the same as run_if_changed in the previous prow flow

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 16, 2024
@OliwiaGowor OliwiaGowor merged commit 358e471 into kyma-project:main Aug 16, 2024
9 checks passed
@OliwiaGowor OliwiaGowor deleted the move-web-build branch September 16, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants