Remove any external linked javascript dependency #101
Conversation
|
/test pre-busola-core-ui |
Merge branch 'main' of https://github.com/kyma-project/busola into internalize-external-dependencies
Wawrzyn321
requested review from
akucharska,
dariadomagala-sap,
parostatkiem-zz and
valentinvieriu
as code owners
shared/package.json
Outdated
| @@ -37,6 +37,7 @@ | |||
| "caniuse-lite": "^1.0.30001081", | |||
| "jsoneditor": "^8.6.1", | |||
| "jwt-decode": "^3.1.2", | |||
| "monaco-editor": "^0.23.0", | |||
There was a problem hiding this comment.
why do we use monaco-editor here and monaco-editor/react in main package.json? Those are 2 different libraries and all our dependencies in the code use monaco-editor/react.
There was a problem hiding this comment.
Additionally, we use monaco-editor/react not only in shared, but also in core-ui. It would make more sense to put it in the main package.json
shared/package.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "test:watch": "jest --watch", | |||
| "build": "webpack --env.production", | |||
| "start:kyma": "webpack --env.development --watch", | |||
| "build:npx": "echo no-op, done during bootstrap" | |||
| "build:npx": "ln -sf ../shared/node_modules/monaco-editor/min/vs ../backend/vs" | |||
There was a problem hiding this comment.
do we need ../shared part in ../shared/node_modules/monaco-editor/min/v?
There was a problem hiding this comment.
Yup, when in my infinite naivety I tried to do ln -s node_modules/monaco-editor/min/vs ../backend/vs, it created a symlink in valid target directory, but didn't take the path into account, so it tried to link busola/backend/node_modules/monaco....
ranch 'internalize-external-dependencies' of github.com:Wawrzyn321/busola into internalize-external-dependencies
Description
Changes proposed in this pull request:
libs/folderjs-yamlfrom coremonaco-editor... we can't link it during the build time (more here), and it's located inshared/. Seeing that I went for symbolic link to thevs/folder (monaco core installed inshared) that would be resolved during runtime. I had to add a SHA for inline script added by Monaco'sloader.BTW I do know what "internalize" means
Related issue(s)