Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide make target to generate CRD with patches #57

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Provide make target to generate CRD with patches #57

merged 3 commits into from
Oct 28, 2022

Conversation

cnvergence
Copy link
Contributor

@cnvergence cnvergence commented Oct 27, 2022 •
edited
Loading

@kyma-bot kyma-bot added area/security size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2022
@cnvergence
Copy link
Contributor Author

/retest

@barchw
Copy link
Contributor

barchw commented Oct 27, 2022

I would say this is unnecessary, as the conversion is applied as kustomization patch in https://github.com/kyma-project/api-gateway/blob/main/config/crd/patches/webhook_in_apirules.yaml

@cnvergence
Copy link
Contributor Author

cnvergence commented Oct 27, 2022 •
edited
Loading

I would say this is unnecessary, as the conversion is applied as kustomization patch in https://github.com/kyma-project/api-gateway/blob/main/config/crd/patches/webhook_in_apirules.yaml

Alright, shall we then generate it with patch and keep the outcome CRD here?

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2022
@cnvergence
Copy link
Contributor Author

/retest

@cnvergence cnvergence changed the title Update crd to match with kyma-project/kyma version Provide make target to generate CRD with patches Oct 27, 2022
@kyma-bot
Copy link
Contributor

@cnvergence: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-api-gateway-lint 20e815b link false /test pull-api-gateway-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 28, 2022
@kyma-bot kyma-bot merged commit b54bb68 into kyma-project:main Oct 28, 2022
@barchw barchw assigned cnvergence and unassigned barchw Oct 28, 2022
@cnvergence cnvergence deleted the crd-mismatch branch October 28, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchw barchw barchw approved these changes

@strekm strekm Awaiting requested review from strekm

@werdes72 werdes72 Awaiting requested review from werdes72

@dariusztutaj dariusztutaj Awaiting requested review from dariusztutaj

Assignees

@cnvergence cnvergence

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cnvergence @barchw @kyma-bot