Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cert Handler CRD Configurable #55

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Oct 26, 2022

  • Make CRD configurable so that the app can generate for different CRDs
  • Adap kustomize resources to use CRD name

Description
Make CRD configurable so that cert-handler can be configured for a different CRD too
Changes proposed in this pull request:

  • Make CRD configurable so that the app can generate for different CRDs
  • Adap kustomize resources to use CRD name

Related issue(s)
#15346

* Make CRD configurable so that the app can generate for different CRDs
* Adap kustomize resources to use CRD name
@kyma-bot kyma-bot added area/security Issues or PRs related to security area/service-mesh Issues or PRs related to service-mesh labels Oct 26, 2022
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2022

CLA assistant check
All committers have signed the CLA.

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2022
Copy link
Contributor

@dariusztutaj dariusztutaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@kyma-bot
Copy link
Contributor

@dariusztutaj: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 27, 2022
@kyma-bot kyma-bot merged commit f334959 into kyma-project:main Oct 27, 2022
@dariusztutaj dariusztutaj removed their assignment Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Issues or PRs related to security area/service-mesh Issues or PRs related to service-mesh lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants