Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for fetching by label v1alpha1 #33

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Test for fetching by label v1alpha1 #33

merged 2 commits into from
Sep 22, 2022

Conversation

barchw
Copy link
Contributor

@barchw barchw commented Sep 22, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add unit test for GetActualState
    Related issue(s)

@kyma-bot kyma-bot added area/security size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2022
barchw
barchw commented Sep 22, 2022
View reviewed changes
internal/processing/processing_test.go Outdated Show resolved Hide resolved
internal/processing/processing_test.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 22, 2022
@strekm strekm added this to the 1.0 milestone Sep 22, 2022
@barchw barchw merged commit 459be10 into kyma-project:main Sep 22, 2022
@barchw barchw deleted the v1alpha1-label-test branch September 22, 2022 08:56
barchw referenced this pull request in barchw/api-gateway-1 Sep 22, 2022
@barchw
Merge pull request #33 from barchw/v1alpha1-label-test
4f0dbbf 
Test for fetching by label v1alpha1
kyma-bot pushed a commit that referenced this pull request Sep 22, 2022
@barchw
Patch label fetching (#35)
413eebf 
* Merge pull request #33 from barchw/v1alpha1-label-test

Test for fetching by label v1alpha1

* Look for v1alpha1 resources by label (#31)

* Look for v1alpha1 resources by label

* Add items without new label

* remove leftover

* Fix typo

* Fetch by old label

* VS >= 1
barchw referenced this pull request in barchw/api-gateway-1 Sep 22, 2022
@barchw
Merge pull request #33 from barchw/v1alpha1-label-test
e2cc385 
Test for fetching by label v1alpha1
kyma-bot pushed a commit that referenced this pull request Sep 22, 2022
@barchw
Cherrypick changes from label fetching fix (#36)
a8b416b 
* Merge pull request #33 from barchw/v1alpha1-label-test

Test for fetching by label v1alpha1

* Cherrypick changes from 1.0.1 patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnvergence cnvergence cnvergence approved these changes

@strekm strekm Awaiting requested review from strekm

@werdes72 werdes72 Awaiting requested review from werdes72

@dariusztutaj dariusztutaj Awaiting requested review from dariusztutaj

Assignees

@cnvergence cnvergence

Labels
lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@barchw @cnvergence @strekm @kyma-bot