Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subresource finalizer #179

Merged
merged 13 commits into from
Jan 24, 2023
Merged

Add subresource finalizer #179

merged 13 commits into from
Jan 24, 2023

Conversation

barchw
Copy link
Contributor

@barchw barchw commented Jan 20, 2023

Description

Changes proposed in this pull request:

  • Add sub resource finaliser to APIRule
  • Remove OwnerRef
  • Remove sub resources in reconcile

Related issue(s)

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/api-gateway Issues or PRs related to api-gateway labels Jan 20, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2023
@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

1 similar comment
@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

@barchw
Copy link
Contributor Author

barchw commented Jan 20, 2023

/test all

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2023
@barchw barchw marked this pull request as ready for review January 23, 2023 08:16
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2023
@barchw barchw linked an issue Jan 23, 2023 that may be closed by this pull request
Finaliser for APIRule CR #162
Closed
8 tasks
@barchw barchw removed a link to an issue Jan 23, 2023
Finaliser for APIRule CR #162
Closed
8 tasks
@barchw barchw mentioned this pull request Jan 23, 2023
Closed
8 tasks
@cnvergence
Copy link
Contributor

Looks good on the cluster

cnvergence
cnvergence approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@cnvergence cnvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 24, 2023
@kyma-bot kyma-bot merged commit fef7cad into kyma-project:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnvergence cnvergence cnvergence approved these changes

@strekm strekm Awaiting requested review from strekm

@werdes72 werdes72 Awaiting requested review from werdes72

@dariusztutaj dariusztutaj Awaiting requested review from dariusztutaj

@videlov videlov Awaiting requested review from videlov

@triffer triffer Awaiting requested review from triffer

Assignees

@cnvergence cnvergence

Labels
area/api-gateway Issues or PRs related to api-gateway lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barchw @kyma-bot @cnvergence