Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved zero downtime test script - increased waiting time, avoided race condition, better logging #1594

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mluk-sap
Copy link
Contributor

@mluk-sap mluk-sap commented Jan 9, 2025

Description

Changes proposed in this pull request:

  • Improved zero downtime test script
  • increased timeout when waiting for the URL to be available (it was the major factor of test flakiness)
  • added 2 seconds delay to reduce the probability of race condition when test finishes
  • added additional check whether the number of requests is too low (<10)
  • more verbose logging, logging failed responses, logging the thread number, etc.

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@mluk-sap mluk-sap requested a review from a team as a code owner January 9, 2025 12:38
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 10, 2025
@mluk-sap mluk-sap merged commit 349fca0 into kyma-project:main Jan 10, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants