Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look at latest image regardless whether the action was fully successful or not #1590

Closed
wants to merge 11 commits into from
Closed

Look at latest image regardless whether the action was fully successful or not #1590

wants to merge 11 commits into from

Conversation

mluk-sap
Copy link
Contributor

@mluk-sap mluk-sap commented Jan 8, 2025

Description

Changes proposed in this pull request:

  • removed 'success' filter when listing for last run of post-main-integration.yaml workflows, previously scheduled builds were taking potentially very old image that is not consistent with current version of tests

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

mluk-sap and others added 11 commits January 4, 2025 11:07
@mluk-sap
Bug fix: don't constantly update APIRule in tests while getting the s…
feed22b 
…tatus
@mluk-sap
Refactored custom domain tests, better test separation
619cf9b
@mluk-sap
hack to run tests
6219719 
(cherry picked from commit 0b7c067)
@mluk-sap
hack to run tests
464f4d4 
(cherry picked from commit 15a8d80)
@mluk-sap
Merge branch 'dont-update-apirules-during-tests'
14c6332 
* dont-update-apirules-during-tests:
  Refactored custom domain tests, better test separation
  Bug fix: don't constantly update APIRule in tests while getting the status
@mluk-sap
Improved logs from zd tests
55b5b2e
@mluk-sap
extended timeout
7668a5d
@mluk-sap
Renamed helper functions (after review)
4b99fcf
@mluk-sap
Changed the way of waiting for the domain to be ready; now using avas…
7d8de74 
…t/retry-go implementation with fixed delay like in other places
@mluk-sap
Merge branch 'dont-update-apirules-during-tests'
75aa6d1 
* dont-update-apirules-during-tests:
  Changed the way of waiting for the domain to be ready; now using avast/retry-go implementation with fixed delay like in other places
  Renamed helper functions (after review)
@mluk-sap
Changed get-latest-sha to get latest sha regardless if it was success…
8cf327f 
…ful or not
@mluk-sap mluk-sap requested a review from a team as a code owner January 8, 2025 09:04
@mluk-sap mluk-sap requested a review from kolodziejczak January 8, 2025 09:04
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 8, 2025
@mluk-sap mluk-sap closed this Jan 8, 2025
@mluk-sap mluk-sap deleted the get-latest-sha-fix branch January 8, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolodziejczak kolodziejczak Awaiting requested review from kolodziejczak

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mluk-sap @kyma-bot