Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL updates to APIRule v2alpha1 integration tests #1507

Merged
merged 9 commits into from
Dec 3, 2024

Conversation

barchw
Copy link
Contributor

@barchw barchw commented Dec 2, 2024

Description

Changes proposed in this pull request:

  • Remove prefix initialiser, switching to universal initialisers
  • Fix generation of namespace name to use a singular instance of RNG, fixing potential namespace conflicts
  • Add a separate optional pre-start hook that scales down oathkeeper, masively speeding up APIGateway startup time
  • Do not teardown when the test fail, allowing for post-run troubleshooting

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@barchw barchw requested a review from a team as a code owner December 2, 2024 11:56
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 2, 2024
triffer
triffer previously approved these changes Dec 3, 2024
Copy link
Contributor

@triffer triffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good changes, thanks for taking the time to clean this up. 👍

tests/integration/pkg/hooks/api-gateway.go Outdated Show resolved Hide resolved
tests/integration/pkg/hooks/api-gateway.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 3, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 3, 2024
@triffer triffer self-requested a review December 3, 2024 14:05
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 3, 2024
@barchw barchw merged commit da4e77a into kyma-project:main Dec 3, 2024
21 checks passed
Ressetkk pushed a commit to Ressetkk/api-gateway that referenced this pull request Jan 3, 2025
* Remove dupplicated inits from apirule tests

* Add template file name

* switch files

* Scale down oathkeeper for faster startup

* Revert delay

* Conditional teardown

* Re-add len parameter to RNG

* Adapt according to review comments
@Ressetkk Ressetkk mentioned this pull request Jan 3, 2025
Ressetkk added a commit that referenced this pull request Jan 7, 2025
* Faster requeue when object has been modified error happens (#1496)

* Faster requeue when object has been modified error happens

* Add api-gateway metrics

* Register metrics

* Add unit test

* Fix lint

* chore: prepare 2.10.2

* QOL updates to APIRule v2alpha1 integration tests (#1507)

* Remove dupplicated inits from apirule tests

* Add template file name

* switch files

* Scale down oathkeeper for faster startup

* Revert delay

* Conditional teardown

* Re-add len parameter to RNG

* Adapt according to review comments

* Full support for special characters in asterisk paths (#1569)

* Full support for special characters in asterisk paths

* Fix regex pattern

* Only use scenario initializer for v2alpha1 tests (#1521)

* Apply suggestions from code review

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>

---------

Co-authored-by: Patryk Strugacz <werdes72@users.noreply.github.com>
Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants