-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QOL updates to APIRule v2alpha1 integration tests #1507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Dec 2, 2024
triffer
previously approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good changes, thanks for taking the time to clean this up. 👍
triffer
approved these changes
Dec 3, 2024
Ressetkk
pushed a commit
to Ressetkk/api-gateway
that referenced
this pull request
Jan 3, 2025
* Remove dupplicated inits from apirule tests * Add template file name * switch files * Scale down oathkeeper for faster startup * Revert delay * Conditional teardown * Re-add len parameter to RNG * Adapt according to review comments
Merged
Ressetkk
added a commit
that referenced
this pull request
Jan 7, 2025
* Faster requeue when object has been modified error happens (#1496) * Faster requeue when object has been modified error happens * Add api-gateway metrics * Register metrics * Add unit test * Fix lint * chore: prepare 2.10.2 * QOL updates to APIRule v2alpha1 integration tests (#1507) * Remove dupplicated inits from apirule tests * Add template file name * switch files * Scale down oathkeeper for faster startup * Revert delay * Conditional teardown * Re-add len parameter to RNG * Adapt according to review comments * Full support for special characters in asterisk paths (#1569) * Full support for special characters in asterisk paths * Fix regex pattern * Only use scenario initializer for v2alpha1 tests (#1521) * Apply suggestions from code review Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com> --------- Co-authored-by: Patryk Strugacz <werdes72@users.noreply.github.com> Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com> Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Pre-Merge Checklist
Related issues