Run reconcilation periodically #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
area/api-gateway
|
/test all |
|
/test pull-api-gateway-build |
kyma-bot
added
size/M
|
/test pull-api-gateway-build |
|
/test pull-api-gateway-build |
barchw
requested review from
strekm,
werdes72,
dariusztutaj,
cnvergence,
videlov and
triffer
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
|
Fixes kyma-project/kyma#10146 |
barchw
changed the title
kyma-bot
added
the
do-not-merge/work-in-progress
kyma-bot
added
size/L
barchw
changed the title
kyma-bot
removed
the
do-not-merge/work-in-progress
werdes72
approved these changes
Dec 30, 2022
|
/cherrypick release-1.2 |
barchw
added a commit
to barchw/api-gateway-1
that referenced
this pull request
Dec 30, 2022
* Requeue after ENV * Don't requeue configMap * Reconcile every time * Requeue faster after error * After fix * Add nil check * Don't run reconcilation again after delete * Move code * Print delete timestamp * Negate deletion timestamp * Print delete timestamp * Print delete timestamp * Don't requeue on delettion * Validate on handler change * Go fmt revert * Add the problems * Add the problems * Switch cases * Unit tests
kyma-bot
pushed a commit
that referenced
this pull request
Dec 30, 2022
* Run reconcilation periodically (#147) * Requeue after ENV * Don't requeue configMap * Reconcile every time * Requeue faster after error * After fix * Add nil check * Don't run reconcilation again after delete * Move code * Print delete timestamp * Negate deletion timestamp * Print delete timestamp * Print delete timestamp * Don't requeue on delettion * Validate on handler change * Go fmt revert * Add the problems * Add the problems * Switch cases * Unit tests * Add reconciliation duration parameter and periodic reconciliation test (#151) * Update apirule_controller.go * Update apirule_controller.go * Update apirule_controller.go * Reconcilation period setup * Add test for reconcilation period * Actually configure from params * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)