Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2alpha1 support for short hosts #1311

Merged
merged 27 commits into from
Sep 26, 2024
Merged

v2alpha1 support for short hosts #1311

merged 27 commits into from
Sep 26, 2024

Conversation

videlov
Copy link
Contributor

@videlov videlov commented Sep 19, 2024

Description

Changes proposed in this pull request:

  • v2alpha1 support for short hosts

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

#1247

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2024
@videlov videlov mentioned this pull request Sep 19, 2024
Closed
20 tasks
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2024
@videlov videlov requested a review from barchw September 24, 2024 08:43
@videlov videlov marked this pull request as ready for review September 24, 2024 08:43
@videlov videlov requested review from a team as code owners September 24, 2024 08:43
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2024
@barchw barchw self-assigned this Sep 24, 2024
barchw
barchw requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@barchw barchw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that using lowercase RFC 1123 in external documentation instead of short host is better, as it is clearly defined (and widely used by K8S).
As for using it internally (e.g. tests/function) names it's probably OK

apis/gateway/v2alpha1/apirule_types.go Outdated Show resolved Hide resolved
apis/gateway/v2alpha1/apirule_types.go Outdated Show resolved Hide resolved
docs/user/custom-resources/apirule/v2alpha1/04-10-apirule-custom-resource.md Outdated Show resolved Hide resolved
internal/validation/v2alpha1/hosts.go Outdated Show resolved Hide resolved
@videlov @barchw
Update internal/validation/v2alpha1/hosts.go
fd39bf4 
Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>
barchw
barchw previously approved these changes Sep 26, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 26, 2024
@videlov @nataliasitko
Update docs/user/custom-resources/apirule/v2alpha1/04-10-apirule-cust…
dd15309 
…om-resource.md

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 26, 2024
@videlov @nataliasitko
Update docs/user/custom-resources/apirule/v2alpha1/04-10-apirule-cust…
b06ed25 
…om-resource.md

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
nataliasitko
nataliasitko previously approved these changes Sep 26, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 26, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 26, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 26, 2024
@videlov videlov merged commit e4d8e37 into kyma-project:main Sep 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchw barchw barchw approved these changes

@nataliasitko nataliasitko nataliasitko approved these changes

Assignees

@nataliasitko nataliasitko

@barchw barchw

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@videlov @kyma-bot @nataliasitko @barchw