This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
Use the current operation instead of relying on assignment state #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
kyma-bot
added
do-not-merge/hold
nyordanoff
changed the title
kyma-bot
removed
the
do-not-merge/work-in-progress
la4ezar
approved these changes
May 27, 2024
dragobt
approved these changes
May 27, 2024
kyma-bot
added
the
approved
la4ezar
approved these changes
May 27, 2024
la4ezar
approved these changes
May 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dragobt, la4ezar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pre-main-compass-schema-migrator-validate |
1 similar comment
|
/test pre-main-compass-schema-migrator-validate |
ognyvrac
removed
the
do-not-merge/hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we determined the formation operation (
assign/unassign) based on the formation assignment state. In this PR we determine the formation operation based on the type of the latest assignment operation for the given assignment.Changes proposed in this pull request:
INSTANCE_CREATOR_DELETINGandINSTANCE_CREATOR_DELETE_ERRORassignment states in favour of a new assignment operation type -INSTANCE_CREATOR_UNASSIGNRelated issue(s)
Pull Request status
chart/compass/values.yamlis updated