Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Fix assign formation not found errors #3804

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

la4ezar
Copy link
Contributor

@la4ezar la4ezar commented Apr 10, 2024

Description
Currently, when assigning something that does not exist, the errors are misleading:

  • "message": "Object not found [object=runtimeLabel]"
  • "message": "Object not found [object=applicationLabel]"
    This PR fixes that.

Changes proposed in this pull request:

  • Fix not-found errors
  • Add unit tests

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@la4ezar la4ezar requested a review from a team as a code owner April 10, 2024 13:23
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. 🦖 team-raptor Team Raptor Label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2024
@la4ezar la4ezar requested review from a team as code owners April 10, 2024 13:24
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2024
@kyma-bot
Copy link

kyma-bot commented Apr 11, 2024

@la4ezar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 15d2b58 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@la4ezar
Copy link
Contributor Author

la4ezar commented Apr 11, 2024

/test pre-main-compass-integration-no-dump

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 11, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivantenevvasilev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@kyma-bot kyma-bot merged commit 81606c1 into main Apr 11, 2024
9 of 10 checks passed
@la4ezar la4ezar deleted the fix-assign-not-found-errors branch April 11, 2024 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files. 🦖 team-raptor Team Raptor Label 👋 request review Review required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants