Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Refactor IAS adapter to be async #3784

Merged
merged 10 commits into from
Apr 9, 2024
Merged

Refactor IAS adapter to be async #3784

merged 10 commits into from
Apr 9, 2024

Conversation

ZdravkoGyurov
Copy link
Contributor

@ZdravkoGyurov ZdravkoGyurov commented Apr 3, 2024 •
edited by stefan-sto
Loading

Description

Changes proposed in this pull request:

  • Refactoring IAS adapter to be an async handler instead of a sync one

Related issue(s)

  • none

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@ZdravkoGyurov ZdravkoGyurov requested a review from a team as a code owner April 3, 2024 09:01
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2024
@ZdravkoGyurov ZdravkoGyurov added 🌐 team-atlas Team Atlas label and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Apr 3, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 3, 2024
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 3, 2024
georgifarashev
georgifarashev reviewed Apr 5, 2024
View reviewed changes
components/ias-adapter/internal/api/internal/handlers/tenant_mapping.go Outdated
type TenantMappingsHandler struct {
Service TenantMappingsService
UCLService
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why embed?

@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 5, 2024
@ZdravkoGyurov ZdravkoGyurov requested review from a team as code owners April 9, 2024 07:44
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 9, 2024
@kyma-bot
Copy link

kyma-bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stefan-sto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@kyma-bot kyma-bot merged commit 6e7c9ce into main Apr 9, 2024
7 of 8 checks passed
@stefan-sto stefan-sto deleted the async-ias-adapter branch April 9, 2024 09:58
@PetarTodorovv PetarTodorovv self-assigned this Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgifarashev georgifarashev georgifarashev left review comments

@stefan-sto stefan-sto stefan-sto approved these changes

Assignees

@PetarTodorovv PetarTodorovv

@stefan-sto stefan-sto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🌐 team-atlas Team Atlas label lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZdravkoGyurov @kyma-bot @georgifarashev @stefan-sto @PetarTodorovv