Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added security context, network policy and tests #39

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

ppatierno
Copy link
Collaborator

@ppatierno ppatierno commented Apr 23, 2020

Signed-off-by: Paolo Patierno ppatierno@live.com

Type of change

  • Enhancement / new feature

Description

Fixes some Jakub's comments like security context and network policy.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Update/write design documentation in ./design
  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno ppatierno requested a review from kyguy April 23, 2020 14:10
Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno ppatierno changed the title Added security context and tests Added security context, network policy and tests Apr 23, 2020
@ppatierno ppatierno merged commit ee9b1a2 into cruise-control-deployment Apr 23, 2020
@ppatierno ppatierno deleted the cruise-control-deployment-paolo branch April 23, 2020 16:20
ppatierno added a commit that referenced this pull request Apr 26, 2020
* Added Cruise Control System Tests

    - Added deployment with CC to Kafka ST resources
    - Added pod name and deployment resources
    - Added CC deployment system test

Signed-off-by: Thomas Cooper <tcooper@redhat.com>

* Cruise Control Deployment

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Add broker capacity estimation and configuration

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Add k8s memory parsing to return different byte multiples

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Refactor Capacity constructor

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Regenerate helm charts

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Addressing some comments

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Addressing more comments

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Addressing more comments (refactoring capacity API, checkOwnerReferences)

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Addressing comments ( capacity properties as strings/validate units in schema)

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Tightening capacity regex; fixing docs

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Another doc fix

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Add missing goal; bump CC version to 2.0.100

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Fix logging and typos

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Addressing comments ( Update allowed disk capacity notation + refactoring)

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Fixing more typos

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Fixing another doc issue

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Securing communication between Cruise Control and Kafka (#37)

* Adding TLS communication between CC and Kafka

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Adding TLS communication between metric reporter and Kafka

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Fixed metrics report to use TLS hostname verification (#38)

Moved metrics topic to Cruise Control configuration
Hiding truststore and keystore passwords in the log

Signed-off-by: Paolo Patierno <ppatierno@live.com>

Co-authored-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Removing CC replicas, refactor Dockerfile + CC dependencies

Signed-off-by: Kyle Liberti <kliberti@redhat.com>

* Added security context, network policy and tests (#39)

* Added security context and tests

Signed-off-by: Paolo Patierno <ppatierno@live.com>

* Added network policy for the cruise control REST API port

Signed-off-by: Paolo Patierno <ppatierno@live.com>

* Added CruiseControl ST to regression tests

Signed-off-by: Paolo Patierno <ppatierno@live.com>

* Fixed NPE on Cruise Control network policy

Signed-off-by: Paolo Patierno <ppatierno@live.com>

Co-authored-by: Thomas Cooper <tcooper@redhat.com>
Co-authored-by: Paolo Patierno <ppatierno@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants