Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Spotify search #115

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Implements Spotify search #115

merged 1 commit into from
Dec 18, 2019

Conversation

whomwah
Copy link
Member

@whomwah whomwah commented Dec 17, 2019

Fixes #110 . Apologies for the fact it's almost impossible to review.

Adds Spotify search to the app. This PR does not use Mopidy to do the search as it's always proved unstable especially when music is playing and more than one person searches. A lot of the current JB crashes are to do with Mopidy search.

This search used the Spotify API in isolation and returns paginated results. You can click on any of those results and they will be added to the playlist and removed from the search results. We'll have to see how that works out in terms of API use. The feature is only available to logged in users.

Screenshot 2019-12-17 18 13 37

@whomwah whomwah self-assigned this Dec 17, 2019
@whomwah whomwah merged commit 900eff1 into master Dec 18, 2019
@whomwah whomwah deleted the jb110 branch December 18, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend search
1 participant