[#89] Store data about who has added a track to the JB #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomajwinter
force-pushed
the
jb89-user-added
branch
2 times, most recently
from
3f2ee78 to
749c308
Compare
added 10 commits
December 19, 2019 09:23
tomajwinter
force-pushed
the
jb89-user-added
branch
from
59e4688 to
154f710
Compare
tomajwinter
changed the title
tomajwinter
commented
Dec 19, 2019
| return TransformTrack(data) | ||
| return new Promise((resolve) => { | ||
| const trackUris = json.map(data => data.uri) | ||
| findTracks(trackUris).then(tracks => { |
There was a problem hiding this comment.
Doing a find on all the playlist IDs in one go rather than inside a loop finding each one
tomajwinter
force-pushed
the
jb89-user-added
branch
from
97859b2 to
ca9bcb3
Compare
whomwah
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a history of which users added the track to the jukebox by storing an array on the new
Trackmodel in the DB.This is displayed quite simply at the moment so awaiting a better design implementation
Any previous plays displayed in a popover