Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .env for mopidy config #105

Merged
merged 4 commits into from
Dec 3, 2019
Merged

Use .env for mopidy config #105

merged 4 commits into from
Dec 3, 2019

Conversation

whomwah
Copy link
Member

@whomwah whomwah commented Dec 1, 2019

This lets users use their .env for the mopidy config variables. Means they can set:

MOPIDY_USERNAME=<SPOTIFY username for Mopidy>
MOPIDY_PASSWORD=<SPOTIFY password for Mopidy>
MOPIDY_CLIENT_ID=<SPOTIFY client id for Mopidy>
MOPIDY_CLIENT_SECRET=<SPOTIFY client secret for Mopidy>

in their .env and it will be copied to the container when it starts up. I needed to remove the volume mount to do this. I think it's only these variable that a user it likely to need to change at the mo.

I've also changed mopidy.local to mopidy to potentially save any issues in the office with the .local domain. I had problems using this domain at home for some reason.

I've also added persistence so you can carry on where you left off.

@whomwah whomwah self-assigned this Dec 1, 2019
@whomwah whomwah requested a review from atothewest December 1, 2019 15:11
Copy link
Contributor

@atothewest atothewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great.

docker-compose-mopidy.yml Show resolved Hide resolved
docker-compose-mopidy.yml Outdated Show resolved Hide resolved
@whomwah whomwah merged commit 5920263 into master Dec 3, 2019
@whomwah whomwah deleted the docker-mopidy-up1 branch December 3, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants