compile protobuf stub code while building #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yaiba
commented
Feb 14, 2023
•
Yaiba
commented
- delete&ignore generated protobuf code in the repo
- add extra step to build proto when building
- using old protobuf compiler version temporary, due to new versioning scheme issue
|
Kudos, SonarCloud Quality Gate passed!
|
Yaiba
commented
Feb 14, 2023
| preconditions: | ||
| - sh: a="libprotoc 3.21.12";b=`protoc --version`;test "$a" = "$b" | ||
| msg: "Protobuf compiler version is not 3.21.12, please install the correct version" | ||
| # TODO: enforce after github action supprort new versionning scheme |
There was a problem hiding this comment.
Disable version check temporary for github workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.