Print output when a subprocess runner with check=True fails. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The raised exception from subprocess.run was suppressing the printed output. This is now fixed and covered by tests. Also updates the test to the non-deprecated version of the call.
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=======================================
Coverage 99.53% 99.54%
=======================================
Files 1 1
Lines 214 218 +4
=======================================
+ Hits 213 217 +4
Misses 1 1
|
kvas-it
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raised exception from subprocess.run was suppressing the printed output. This is now fixed and covered by tests.
Also updates the test to use non-deprecated script runner parameters.