Add type-hinting, newer Python versions, and test on Windows. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix and mark issues with Windows. Windows paths were being added to code without being escaped correctly. Windows does not treat Python scripts as executables for `shutil.which`, so tests relying on this will fail. Update older pytest fixtures to newer ones. Add Mypy to Tox. Currently no issues are found with `mypy --strict`.
`easy_install` is missing from too many environments to be used in tests and has encoding issues on Windows. It has been replaced with a custom script containing `sys.exit(None)`.
Coverage showed that no tests were using `sys.exit(<int>)`.
|
I fixed the Windows env issues by copying the |
The issue might be too specific to require this fix. Something like a warning might be better.
kvas-it
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests were failing when run on Windows. I have fixed them and marked the rest:
shutil.which, so tests relying on this will fail.SYSTEMROOTenvironment variable is required to initialize Python correctly. "subprocess" mode often crashes without it. This has been fixed.easy_installhas encoding issues on Windows. It's also missing from many environments so I've replaced the test using it with a custom script.Updated some older pytest fixtures to newer ones. Most of the current fixtures have replacements and I skipped over a lot of them.
Added Mypy to Tox. I've fully typed the code so that it passed
mypy --strictbut I didn't add--strictto the linting tests yet.Added Python versions up to 3.11 to CI, also added Windows to CI.
I tested coverage, only two lines in
pytest_console_scripts.pyare missing from a Windows test.