Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list-contains binding #4644

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Fix list-contains binding #4644

merged 3 commits into from
Dec 17, 2024

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Dec 17, 2024

Description

This PR solves a list_contains binding issue as reported by user in issue #4641

Fixes #4641

Copy link

Benchmark Result

Master commit hash: 45013c15a8468c484614370ba1cc9b7e476a59fc
Branch commit hash: 8fcd34228deea638caa8f6fa72ec577c7bee2621

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 646.80 648.90 -2.10 (-0.32%)
aggregation q28 11903.80 11682.05 221.75 (1.90%)
filter q14 126.12 125.74 0.38 (0.30%)
filter q15 125.47 128.46 -2.99 (-2.33%)
filter q16 302.52 315.75 -13.23 (-4.19%)
filter q17 445.98 444.63 1.36 (0.30%)
filter q18 1993.39 1991.88 1.51 (0.08%)
filter zonemap-node 87.49 86.55 0.94 (1.09%)
filter zonemap-node-lhs-cast 86.51 86.17 0.33 (0.39%)
filter zonemap-rel 5719.22 5709.56 9.66 (0.17%)
fixed_size_expr_evaluator q07 572.40 572.49 -0.09 (-0.02%)
fixed_size_expr_evaluator q08 802.74 803.29 -0.54 (-0.07%)
fixed_size_expr_evaluator q09 800.35 804.64 -4.29 (-0.53%)
fixed_size_expr_evaluator q10 235.76 236.06 -0.30 (-0.13%)
fixed_size_expr_evaluator q11 228.75 228.26 0.49 (0.21%)
fixed_size_expr_evaluator q12 226.00 225.33 0.66 (0.29%)
fixed_size_expr_evaluator q13 1458.17 1452.82 5.35 (0.37%)
fixed_size_seq_scan q23 111.82 112.11 -0.29 (-0.26%)
join q29 617.66 636.11 -18.45 (-2.90%)
join q30 1608.75 1538.05 70.71 (4.60%)
join q31 5.36 7.22 -1.86 (-25.76%)
join SelectiveTwoHopJoin 52.45 56.38 -3.93 (-6.96%)
ldbc_snb_ic q35 2567.33 2652.94 -85.61 (-3.23%)
ldbc_snb_ic q36 573.51 540.74 32.77 (6.06%)
ldbc_snb_is q32 4.30 3.41 0.89 (26.16%)
ldbc_snb_is q33 12.50 12.12 0.38 (3.13%)
ldbc_snb_is q34 1.18 1.18 -0.00 (-0.11%)
multi-rel multi-rel-large-scan 1231.94 1201.36 30.59 (2.55%)
multi-rel multi-rel-lookup 8.30 28.11 -19.81 (-70.47%)
multi-rel multi-rel-small-scan 81.50 94.65 -13.15 (-13.90%)
order_by q25 129.76 128.98 0.78 (0.60%)
order_by q26 448.44 450.91 -2.48 (-0.55%)
order_by q27 1474.36 1498.71 -24.35 (-1.62%)
recursive_join recursive-join-bidirection 302.23 307.56 -5.33 (-1.73%)
recursive_join recursive-join-dense 7451.08 6215.03 1236.05 (19.89%)
recursive_join recursive-join-path 23838.15 23775.95 62.20 (0.26%)
recursive_join recursive-join-sparse 14700.56 14611.94 88.61 (0.61%)
recursive_join recursive-join-trail 7373.03 6561.09 811.93 (12.37%)
scan_after_filter q01 172.32 172.92 -0.60 (-0.35%)
scan_after_filter q02 155.70 157.24 -1.54 (-0.98%)
shortest_path_ldbc100 q37 77.86 87.13 -9.27 (-10.64%)
shortest_path_ldbc100 q38 354.54 369.42 -14.88 (-4.03%)
shortest_path_ldbc100 q39 52.64 58.80 -6.15 (-10.47%)
shortest_path_ldbc100 q40 383.54 398.32 -14.77 (-3.71%)
var_size_expr_evaluator q03 2103.03 2104.12 -1.09 (-0.05%)
var_size_expr_evaluator q04 2287.50 2278.12 9.38 (0.41%)
var_size_expr_evaluator q05 2559.95 2726.42 -166.48 (-6.11%)
var_size_expr_evaluator q06 1355.68 1348.45 7.23 (0.54%)
var_size_seq_scan q19 1480.95 1463.03 17.92 (1.22%)
var_size_seq_scan q20 2688.13 2651.30 36.83 (1.39%)
var_size_seq_scan q21 2291.41 2252.35 39.06 (1.73%)
var_size_seq_scan q22 128.67 125.65 3.02 (2.41%)

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.52%. Comparing base (45013c1) to head (957cf84).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4644   +/-   ##
=======================================
  Coverage   86.52%   86.52%           
=======================================
  Files        1369     1369           
  Lines       57983    57983           
  Branches     7208     7209    +1     
=======================================
  Hits        50168    50168           
  Misses       7647     7647           
  Partials      168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Result

Master commit hash: 45013c15a8468c484614370ba1cc9b7e476a59fc
Branch commit hash: aa51130cf074473922420bd4e6a9c60845fff231

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 643.46 648.90 -5.44 (-0.84%)
aggregation q28 11520.22 11682.05 -161.83 (-1.39%)
filter q14 127.05 125.74 1.31 (1.04%)
filter q15 124.24 128.46 -4.22 (-3.28%)
filter q16 303.67 315.75 -12.08 (-3.82%)
filter q17 444.71 444.63 0.08 (0.02%)
filter q18 1998.60 1991.88 6.72 (0.34%)
filter zonemap-node 86.13 86.55 -0.43 (-0.49%)
filter zonemap-node-lhs-cast 88.73 86.17 2.56 (2.97%)
filter zonemap-rel 5766.35 5709.56 56.79 (0.99%)
fixed_size_expr_evaluator q07 572.72 572.49 0.22 (0.04%)
fixed_size_expr_evaluator q08 801.03 803.29 -2.25 (-0.28%)
fixed_size_expr_evaluator q09 1039.91 804.64 235.26 (29.24%)
fixed_size_expr_evaluator q10 235.53 236.06 -0.52 (-0.22%)
fixed_size_expr_evaluator q11 228.49 228.26 0.23 (0.10%)
fixed_size_expr_evaluator q12 225.27 225.33 -0.06 (-0.03%)
fixed_size_expr_evaluator q13 1452.27 1452.82 -0.56 (-0.04%)
fixed_size_seq_scan q23 109.48 112.11 -2.63 (-2.35%)
join q29 593.67 636.11 -42.45 (-6.67%)
join q30 1519.11 1538.05 -18.94 (-1.23%)
join q31 5.14 7.22 -2.07 (-28.74%)
join SelectiveTwoHopJoin 51.50 56.38 -4.88 (-8.65%)
ldbc_snb_ic q35 2582.00 2652.94 -70.94 (-2.67%)
ldbc_snb_ic q36 521.68 540.74 -19.06 (-3.52%)
ldbc_snb_is q32 5.84 3.41 2.43 (71.19%)
ldbc_snb_is q33 11.57 12.12 -0.55 (-4.54%)
ldbc_snb_is q34 1.19 1.18 0.01 (0.45%)
multi-rel multi-rel-large-scan 1216.09 1201.36 14.74 (1.23%)
multi-rel multi-rel-lookup 33.51 28.11 5.40 (19.19%)
multi-rel multi-rel-small-scan 88.48 94.65 -6.17 (-6.52%)
order_by q25 133.57 128.98 4.59 (3.56%)
order_by q26 447.98 450.91 -2.93 (-0.65%)
order_by q27 1477.75 1498.71 -20.96 (-1.40%)
recursive_join recursive-join-bidirection 286.71 307.56 -20.85 (-6.78%)
recursive_join recursive-join-dense 7448.16 6215.03 1233.13 (19.84%)
recursive_join recursive-join-path 23824.06 23775.95 48.11 (0.20%)
recursive_join recursive-join-sparse 13814.04 14611.94 -797.91 (-5.46%)
recursive_join recursive-join-trail 7356.43 6561.09 795.33 (12.12%)
scan_after_filter q01 173.22 172.92 0.30 (0.17%)
scan_after_filter q02 157.10 157.24 -0.14 (-0.09%)
shortest_path_ldbc100 q37 87.65 87.13 0.52 (0.59%)
shortest_path_ldbc100 q38 360.27 369.42 -9.16 (-2.48%)
shortest_path_ldbc100 q39 57.71 58.80 -1.09 (-1.85%)
shortest_path_ldbc100 q40 443.14 398.32 44.83 (11.25%)
var_size_expr_evaluator q03 2122.07 2104.12 17.94 (0.85%)
var_size_expr_evaluator q04 2292.15 2278.12 14.03 (0.62%)
var_size_expr_evaluator q05 2556.95 2726.42 -169.47 (-6.22%)
var_size_expr_evaluator q06 1341.82 1348.45 -6.63 (-0.49%)
var_size_seq_scan q19 1483.35 1463.03 20.31 (1.39%)
var_size_seq_scan q20 2689.55 2651.30 38.24 (1.44%)
var_size_seq_scan q21 2297.06 2252.35 44.71 (1.98%)
var_size_seq_scan q22 128.35 125.65 2.70 (2.15%)

@acquamarin acquamarin merged commit 881912a into master Dec 17, 2024
25 checks passed
@acquamarin acquamarin deleted the list-contains-fix branch December 17, 2024 19:48
SterlingT3485 pushed a commit that referenced this pull request Dec 17, 2024
ray6080 pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: IN operator (list_contains) returns wrong results when passed as a parameter in Python
2 participants