-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix attach kuzu in in-mem mode #4177
Conversation
Benchmark ResultMaster commit hash:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4177 +/- ##
=======================================
Coverage 84.09% 84.09%
=======================================
Files 1332 1332
Lines 53250 53251 +1
Branches 7428 7427 -1
=======================================
+ Hits 44778 44782 +4
+ Misses 8300 8297 -3
Partials 172 172 ☔ View full report in Codecov by Sentry. |
Benchmark ResultMaster commit hash:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u also add extension test to codecov in mem run?
The extension tests need to recompile the gtest and test files so we can't run extension tests with main tests. We should consider refactoring the testing framework so we don't have to recompile the testing framework when running extension tests. |
(cherry picked from commit de6226e)
Description
This PR fixes attaching kuzu database in in-memory mode, and add ci to run extension test in in-mem mode.