Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attach kuzu in in-mem mode #4177

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix attach kuzu in in-mem mode #4177

merged 2 commits into from
Sep 3, 2024

Conversation

acquamarin
Copy link
Collaborator

Description

This PR fixes attaching kuzu database in in-memory mode, and add ci to run extension test in in-mem mode.

Copy link

github-actions bot commented Sep 3, 2024

Benchmark Result

Master commit hash: fca1bbd4a692cd8a04da34dac2c035e4e30ef93f
Branch commit hash: 5a921815d5794917c0a389d3ac72fc34d3d26968

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 673.39 678.21 -4.83 (-0.71%)
aggregation q28 10960.01 11350.44 -390.43 (-3.44%)
filter q14 151.41 158.42 -7.01 (-4.42%)
filter q15 156.10 160.68 -4.59 (-2.86%)
filter q16 326.57 335.68 -9.11 (-2.71%)
filter q17 472.57 480.71 -8.14 (-1.69%)
filter q18 1939.50 1932.79 6.71 (0.35%)
fixed_size_expr_evaluator q07 562.90 570.15 -7.25 (-1.27%)
fixed_size_expr_evaluator q08 775.95 787.69 -11.73 (-1.49%)
fixed_size_expr_evaluator q09 776.96 791.98 -15.01 (-1.90%)
fixed_size_expr_evaluator q10 264.97 273.60 -8.63 (-3.15%)
fixed_size_expr_evaluator q11 261.54 267.64 -6.10 (-2.28%)
fixed_size_expr_evaluator q12 259.08 266.82 -7.74 (-2.90%)
fixed_size_expr_evaluator q13 1502.22 1497.42 4.80 (0.32%)
fixed_size_seq_scan q23 143.92 153.19 -9.27 (-6.05%)
join q31 13.20 13.59 -0.38 (-2.81%)
ldbc_snb_ic q35 749.76 872.48 -122.72 (-14.07%)
ldbc_snb_ic q36 46.40 49.89 -3.50 (-7.01%)
ldbc_snb_is q32 9.08 8.84 0.23 (2.63%)
ldbc_snb_is q33 16.58 14.14 2.45 (17.29%)
ldbc_snb_is q34 9.00 8.05 0.95 (11.86%)
multi-rel multi-rel-large-scan 2876.02 2760.74 115.27 (4.18%)
multi-rel multi-rel-lookup 43.48 64.01 -20.53 (-32.07%)
multi-rel multi-rel-small-scan 53.95 46.49 7.46 (16.06%)
order_by q25 153.57 165.97 -12.40 (-7.47%)
order_by q26 486.07 487.90 -1.82 (-0.37%)
order_by q27 1450.99 1439.60 11.39 (0.79%)
scan_after_filter q01 198.59 206.26 -7.67 (-3.72%)
scan_after_filter q02 187.45 196.00 -8.55 (-4.36%)
shortest_path_ldbc100 q39 76.34 74.80 1.54 (2.05%)
var_size_expr_evaluator q03 2105.81 2113.44 -7.63 (-0.36%)
var_size_expr_evaluator q04 2293.67 2296.10 -2.43 (-0.11%)
var_size_expr_evaluator q05 2586.77 2728.74 -141.97 (-5.20%)
var_size_expr_evaluator q06 1415.58 1397.48 18.11 (1.30%)
var_size_seq_scan q19 1506.95 1496.17 10.78 (0.72%)
var_size_seq_scan q20 3228.00 3311.94 -83.94 (-2.53%)
var_size_seq_scan q21 2466.56 2505.24 -38.68 (-1.54%)
var_size_seq_scan q22 135.22 136.57 -1.36 (-0.99%)

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.09%. Comparing base (fca1bbd) to head (3b2d805).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/main/attached_database.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4177   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files        1332     1332           
  Lines       53250    53251    +1     
  Branches     7428     7427    -1     
=======================================
+ Hits        44778    44782    +4     
+ Misses       8300     8297    -3     
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 3, 2024

Benchmark Result

Master commit hash: 7b50ae6f5d4209b8b50cc60173b95d626cb6e739
Branch commit hash: 5fa227e40e54b0b9f018210af5e710f61a0a1608

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 672.80 679.24 -6.44 (-0.95%)
aggregation q28 11064.64 11480.68 -416.03 (-3.62%)
filter q14 151.67 158.92 -7.25 (-4.56%)
filter q15 154.29 161.74 -7.45 (-4.61%)
filter q16 329.96 334.53 -4.57 (-1.37%)
filter q17 476.76 480.03 -3.28 (-0.68%)
filter q18 1957.57 1942.58 14.98 (0.77%)
fixed_size_expr_evaluator q07 562.43 572.97 -10.54 (-1.84%)
fixed_size_expr_evaluator q08 770.91 780.19 -9.28 (-1.19%)
fixed_size_expr_evaluator q09 773.14 783.39 -10.24 (-1.31%)
fixed_size_expr_evaluator q10 266.06 274.49 -8.43 (-3.07%)
fixed_size_expr_evaluator q11 260.00 268.97 -8.97 (-3.33%)
fixed_size_expr_evaluator q12 259.51 266.20 -6.69 (-2.51%)
fixed_size_expr_evaluator q13 1502.03 1492.33 9.71 (0.65%)
fixed_size_seq_scan q23 139.79 153.56 -13.77 (-8.97%)
join q31 13.31 12.82 0.48 (3.77%)
ldbc_snb_ic q35 864.40 724.34 140.06 (19.34%)
ldbc_snb_ic q36 46.18 55.56 -9.38 (-16.88%)
ldbc_snb_is q32 8.46 9.69 -1.22 (-12.64%)
ldbc_snb_is q33 15.76 18.77 -3.01 (-16.02%)
ldbc_snb_is q34 8.06 8.91 -0.84 (-9.48%)
multi-rel multi-rel-large-scan 2906.20 2795.35 110.85 (3.97%)
multi-rel multi-rel-lookup 57.61 60.72 -3.11 (-5.13%)
multi-rel multi-rel-small-scan 48.14 60.45 -12.31 (-20.37%)
order_by q25 157.17 166.48 -9.31 (-5.59%)
order_by q26 481.17 486.41 -5.24 (-1.08%)
order_by q27 1445.26 1442.47 2.79 (0.19%)
scan_after_filter q01 198.27 206.27 -8.01 (-3.88%)
scan_after_filter q02 186.74 195.92 -9.19 (-4.69%)
shortest_path_ldbc100 q39 74.43 74.59 -0.16 (-0.21%)
var_size_expr_evaluator q03 2103.49 2094.38 9.10 (0.43%)
var_size_expr_evaluator q04 2265.39 2288.79 -23.40 (-1.02%)
var_size_expr_evaluator q05 2604.91 2720.59 -115.69 (-4.25%)
var_size_expr_evaluator q06 1416.25 1397.59 18.66 (1.33%)
var_size_seq_scan q19 1504.36 1493.10 11.26 (0.75%)
var_size_seq_scan q20 3250.16 3323.62 -73.45 (-2.21%)
var_size_seq_scan q21 2453.20 2513.41 -60.21 (-2.40%)
var_size_seq_scan q22 135.10 139.56 -4.45 (-3.19%)

@acquamarin acquamarin requested a review from ray6080 September 3, 2024 05:06
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u also add extension test to codecov in mem run?

@acquamarin
Copy link
Collaborator Author

Can u also add extension test to codecov in mem run?

The extension tests need to recompile the gtest and test files so we can't run extension tests with main tests.

We should consider refactoring the testing framework so we don't have to recompile the testing framework when running extension tests.

@acquamarin acquamarin merged commit de6226e into master Sep 3, 2024
23 of 24 checks passed
@acquamarin acquamarin deleted the fix-in-mem-mode-attach branch September 3, 2024 15:07
ray6080 pushed a commit that referenced this pull request Oct 11, 2024
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants