-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http file cache improve #4159
Http file cache improve #4159
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4159 +/- ##
=======================================
Coverage 84.05% 84.05%
=======================================
Files 1330 1330
Lines 53174 53174
Branches 7418 7418
=======================================
+ Hits 44694 44695 +1
+ Misses 8308 8307 -1
Partials 172 172 ☔ View full report in Codecov by Sentry. |
Benchmark ResultMaster commit hash:
|
Benchmark ResultMaster commit hash:
|
(cherry picked from commit f100588)
Description
This PR improves the http file cache performance by avoiding retriving the metadata information if the file cache is present.
Solves #4010
Performance number:
We run the same query twice in the same transaction:
load from 's3://kuzu-test/dataset/ldbc10/comment_0_0.csv'(header=true,delim='|') return *;
LDBC10: 2.1 GB
This branch:
Master: