Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user defined type casting #4156

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix user defined type casting #4156

merged 2 commits into from
Aug 28, 2024

Conversation

acquamarin
Copy link
Collaborator

Description

Fixes user defined casting issues.

@acquamarin acquamarin requested a review from andyfengHKU August 27, 2024 06:08
Copy link

Benchmark Result

Master commit hash: 0c2dc1cdcb669dae6bf2ae9f379dc2e88745981b
Branch commit hash: e6b2ad735d6cfd644ea82b622105ff6813d265f4

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 670.28 674.84 -4.56 (-0.68%)
aggregation q28 11680.87 11292.87 388.00 (3.44%)
filter q14 151.69 151.66 0.03 (0.02%)
filter q15 151.58 153.34 -1.76 (-1.15%)
filter q16 329.88 326.38 3.49 (1.07%)
filter q17 475.09 475.89 -0.80 (-0.17%)
filter q18 1956.82 1991.16 -34.33 (-1.72%)
fixed_size_expr_evaluator q07 565.99 567.23 -1.24 (-0.22%)
fixed_size_expr_evaluator q08 774.92 780.37 -5.45 (-0.70%)
fixed_size_expr_evaluator q09 776.66 778.87 -2.21 (-0.28%)
fixed_size_expr_evaluator q10 267.81 266.61 1.21 (0.45%)
fixed_size_expr_evaluator q11 262.83 260.24 2.59 (0.99%)
fixed_size_expr_evaluator q12 262.74 259.22 3.52 (1.36%)
fixed_size_expr_evaluator q13 1503.15 1503.67 -0.52 (-0.03%)
fixed_size_seq_scan q23 144.15 143.10 1.04 (0.73%)
join q31 13.39 13.43 -0.04 (-0.34%)
ldbc_snb_ic q35 885.66 793.18 92.47 (11.66%)
ldbc_snb_ic q36 47.15 51.40 -4.25 (-8.27%)
ldbc_snb_is q32 10.28 9.54 0.74 (7.77%)
ldbc_snb_is q33 18.23 18.25 -0.03 (-0.16%)
ldbc_snb_is q34 9.48 8.81 0.67 (7.57%)
multi-rel multi-rel-large-scan 2916.16 2762.21 153.95 (5.57%)
multi-rel multi-rel-lookup 70.92 60.57 10.36 (17.10%)
multi-rel multi-rel-small-scan 59.34 53.75 5.59 (10.41%)
order_by q25 155.81 155.72 0.09 (0.06%)
order_by q26 470.66 474.08 -3.42 (-0.72%)
order_by q27 1444.74 1434.70 10.04 (0.70%)
scan_after_filter q01 201.55 199.58 1.97 (0.99%)
scan_after_filter q02 186.59 187.95 -1.35 (-0.72%)
shortest_path_ldbc100 q39 79.48 75.28 4.20 (5.57%)
var_size_expr_evaluator q03 2102.98 2089.41 13.57 (0.65%)
var_size_expr_evaluator q04 2278.49 2282.59 -4.10 (-0.18%)
var_size_expr_evaluator q05 2652.79 2684.46 -31.66 (-1.18%)
var_size_expr_evaluator q06 1447.71 1399.94 47.76 (3.41%)
var_size_seq_scan q19 1493.40 1484.99 8.40 (0.57%)
var_size_seq_scan q20 3173.37 3197.46 -24.09 (-0.75%)
var_size_seq_scan q21 2428.67 2463.89 -35.22 (-1.43%)
var_size_seq_scan q22 134.83 135.78 -0.95 (-0.70%)

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.05%. Comparing base (0c2dc1c) to head (1742328).
Report is 2 commits behind head on master.

Files Patch % Lines
src/function/vector_cast_functions.cpp 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4156   +/-   ##
=======================================
  Coverage   84.05%   84.05%           
=======================================
  Files        1330     1330           
  Lines       53143    53171   +28     
  Branches     7407     7416    +9     
=======================================
+ Hits        44668    44693   +25     
- Misses       8304     8306    +2     
- Partials      171      172    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/common/types/types.cpp Show resolved Hide resolved
@acquamarin acquamarin merged commit 27c5ef5 into master Aug 28, 2024
23 checks passed
@acquamarin acquamarin deleted the fix-udt-casting branch August 28, 2024 04:33
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants