Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Connection::query in rust call the C++ query function instead of using prepare+execute #4117

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

benjaminwinger
Copy link
Collaborator

Originally just a simplification as the C++ Connection::query function was also originally also doing this.

Fixes #4116

Copy link

Benchmark Result

Master commit hash: e90380ea89fd37a7fd29bf933d7e81ab1af51318
Branch commit hash: c441d814d0a97480f990d857f12e54c2df119cfd

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 672.55 673.41 -0.86 (-0.13%)
aggregation q28 11940.05 11855.83 84.22 (0.71%)
filter q14 150.70 150.16 0.54 (0.36%)
filter q15 151.46 154.33 -2.87 (-1.86%)
filter q16 325.36 325.04 0.32 (0.10%)
filter q17 475.12 475.59 -0.47 (-0.10%)
filter q18 1921.91 1926.26 -4.36 (-0.23%)
fixed_size_expr_evaluator q07 562.85 564.10 -1.25 (-0.22%)
fixed_size_expr_evaluator q08 783.42 775.26 8.16 (1.05%)
fixed_size_expr_evaluator q09 774.99 773.71 1.28 (0.16%)
fixed_size_expr_evaluator q10 266.42 267.27 -0.85 (-0.32%)
fixed_size_expr_evaluator q11 261.78 262.27 -0.49 (-0.19%)
fixed_size_expr_evaluator q12 258.29 258.08 0.21 (0.08%)
fixed_size_expr_evaluator q13 1496.84 1489.55 7.28 (0.49%)
fixed_size_seq_scan q23 145.28 143.99 1.29 (0.90%)
join q31 11.65 11.80 -0.15 (-1.28%)
ldbc_snb_ic q35 857.31 766.22 91.10 (11.89%)
ldbc_snb_ic q36 47.69 46.78 0.92 (1.96%)
ldbc_snb_is q32 9.08 9.51 -0.44 (-4.59%)
ldbc_snb_is q33 13.65 18.00 -4.34 (-24.13%)
ldbc_snb_is q34 8.04 8.17 -0.13 (-1.57%)
multi-rel multi-rel-large-scan 2874.76 5573.63 -2698.87 (-48.42%)
multi-rel multi-rel-lookup 49.94 50.17 -0.23 (-0.46%)
multi-rel multi-rel-small-scan 51.67 74.62 -22.95 (-30.75%)
order_by q25 154.37 156.62 -2.25 (-1.43%)
order_by q26 479.16 478.48 0.68 (0.14%)
order_by q27 1416.57 1422.63 -6.06 (-0.43%)
scan_after_filter q01 199.57 200.39 -0.82 (-0.41%)
scan_after_filter q02 185.81 187.77 -1.96 (-1.04%)
shortest_path_ldbc100 q39 113.08 112.21 0.87 (0.77%)
var_size_expr_evaluator q03 2076.06 2078.03 -1.96 (-0.09%)
var_size_expr_evaluator q04 2229.80 2212.82 16.97 (0.77%)
var_size_expr_evaluator q05 2703.31 2731.49 -28.18 (-1.03%)
var_size_expr_evaluator q06 1374.15 1374.81 -0.66 (-0.05%)
var_size_seq_scan q19 1478.74 1467.09 11.65 (0.79%)
var_size_seq_scan q20 3122.28 3135.81 -13.52 (-0.43%)
var_size_seq_scan q21 2402.43 2402.99 -0.57 (-0.02%)
var_size_seq_scan q22 132.43 131.96 0.47 (0.36%)

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (e90380e) to head (fe73b18).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4117   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files        1305     1305           
  Lines       51376    51376           
  Branches     7137     7137           
=======================================
+ Hits        43148    43149    +1     
+ Misses       8079     8078    -1     
  Partials      149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit 3faf6d0 into master Aug 21, 2024
23 checks passed
@andyfengHKU andyfengHKU deleted the rust-query branch August 21, 2024 16:41
ray6080 pushed a commit that referenced this pull request Oct 11, 2024
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot run multiple statements per query through Rust API
2 participants